diff options
author | Kitson Kelly <me@kitsonkelly.com> | 2020-04-12 01:42:02 +1000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-04-11 11:42:02 -0400 |
commit | fc4819e1e0624b9377913932202bc31f5a25bab4 (patch) | |
tree | 98604a5ce1ff29c1a900c0c37b7307072a48fa6a /cli/js/tests/event_target_test.ts | |
parent | 2b362bef8523f3d8c05ce5d3d4b4a839b669568d (diff) |
refactor: Event and EventTarget implementations (#4707)
Refactors Event and EventTarget so that they better encapsulate their
non-public data as well as are more forward compatible with things like
DOM Nodes.
Moves `dom_types.ts` -> `dom_types.d.ts` which was always the intention,
it was a legacy of when we used to build the types from the code and the
limitations of the compiler. There was a lot of cruft in `dom_types`
which shouldn't have been there, and mis-alignment to the DOM standards.
This generally has been eliminated, though we still have some minor
differences from the DOM (like the removal of some deprecated
methods/properties).
Adds `DOMException`. Strictly it shouldn't inherit from `Error`, but
most browsers provide a stack trace when one is thrown, so the behaviour
in Deno actually better matches the browser.
`Event` still doesn't log to console like it does in the browser. I
wanted to get this raised and that could be an enhancement later on (it
currently doesn't either).
Diffstat (limited to 'cli/js/tests/event_target_test.ts')
-rw-r--r-- | cli/js/tests/event_target_test.ts | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/cli/js/tests/event_target_test.ts b/cli/js/tests/event_target_test.ts index ece4b5dba..0c4eb4d0d 100644 --- a/cli/js/tests/event_target_test.ts +++ b/cli/js/tests/event_target_test.ts @@ -35,18 +35,6 @@ unitTest(function constructedEventTargetCanBeUsedAsExpected(): void { assertEquals(callCount, 2); }); -// TODO(ry) Should AddEventListenerOptions and EventListenerOptions be exposed -// from the public API? - -interface AddEventListenerOptions extends EventListenerOptions { - once?: boolean; - passive?: boolean; -} - -interface EventListenerOptions { - capture?: boolean; -} - unitTest(function anEventTargetCanBeSubclassed(): void { class NicerEventTarget extends EventTarget { on( |