refactor: rewrite testPerm into unitTest (#4231)

Rewrite "testPerm" helper function used for testing of internal 
runtime code. It's been renamed to "unitTest" and provides API that
is extensible in the future by accepting optional "UnitTestOptions" 
argument. "test" helper was also removed and replaced by
overloaded version of "unitTest" that takes only function argument.

"UnitTestOptions" currently supports "perms" and "skip"
options, where former works exactly as first argument to "testPerm"
did, while the latter allows to conditionally skip tests. 

1 files changed, 38 insertions, 30 deletions

diff --git a/cli/js/read_link_test.ts b/cli/js/read_link_test.ts
index 498b65c0a..409f37110 100644
--- a/cli/js/read_link_test.ts
+++ b/cli/js/read_link_test.ts
@@ -1,21 +1,26 @@
 // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
-import { testPerm, assert, assertEquals } from "./test_util.ts";
+import { unitTest, assert, assertEquals } from "./test_util.ts";
 
-testPerm({ write: true, read: true }, function readlinkSyncSuccess(): void {
-  const testDir = Deno.makeTempDirSync();
-  const target = testDir + "/target";
-  const symlink = testDir + "/symln";
-  Deno.mkdirSync(target);
-  // TODO Add test for Windows once symlink is implemented for Windows.
-  // See https://github.com/denoland/deno/issues/815.
-  if (Deno.build.os !== "win") {
-    Deno.symlinkSync(target, symlink);
-    const targetPath = Deno.readlinkSync(symlink);
-    assertEquals(targetPath, target);
+unitTest(
+  { perms: { write: true, read: true } },
+  function readlinkSyncSuccess(): void {
+    const testDir = Deno.makeTempDirSync();
+    const target = testDir + "/target";
+    const symlink = testDir + "/symln";
+    Deno.mkdirSync(target);
+    // TODO Add test for Windows once symlink is implemented for Windows.
+    // See https://github.com/denoland/deno/issues/815.
+    if (Deno.build.os !== "win") {
+      Deno.symlinkSync(target, symlink);
+      const targetPath = Deno.readlinkSync(symlink);
+      assertEquals(targetPath, target);
+    }
   }
-});
+);
 
-testPerm({ read: false }, async function readlinkSyncPerm(): Promise<void> {
+unitTest({ perms: { read: false } }, async function readlinkSyncPerm(): Promise<
+  void
+> {
   let caughtError = false;
   try {
     Deno.readlinkSync("/symlink");
@@ -26,7 +31,7 @@ testPerm({ read: false }, async function readlinkSyncPerm(): Promise<void> {
   assert(caughtError);
 });
 
-testPerm({ read: true }, function readlinkSyncNotFound(): void {
+unitTest({ perms: { read: true } }, function readlinkSyncNotFound(): void {
   let caughtError = false;
   let data;
   try {
@@ -39,23 +44,26 @@ testPerm({ read: true }, function readlinkSyncNotFound(): void {
   assertEquals(data, undefined);
 });
 
-testPerm({ write: true, read: true }, async function readlinkSuccess(): Promise<
-  void
-> {
-  const testDir = Deno.makeTempDirSync();
-  const target = testDir + "/target";
-  const symlink = testDir + "/symln";
-  Deno.mkdirSync(target);
-  // TODO Add test for Windows once symlink is implemented for Windows.
-  // See https://github.com/denoland/deno/issues/815.
-  if (Deno.build.os !== "win") {
-    Deno.symlinkSync(target, symlink);
-    const targetPath = await Deno.readlink(symlink);
-    assertEquals(targetPath, target);
+unitTest(
+  { perms: { write: true, read: true } },
+  async function readlinkSuccess(): Promise<void> {
+    const testDir = Deno.makeTempDirSync();
+    const target = testDir + "/target";
+    const symlink = testDir + "/symln";
+    Deno.mkdirSync(target);
+    // TODO Add test for Windows once symlink is implemented for Windows.
+    // See https://github.com/denoland/deno/issues/815.
+    if (Deno.build.os !== "win") {
+      Deno.symlinkSync(target, symlink);
+      const targetPath = await Deno.readlink(symlink);
+      assertEquals(targetPath, target);
+    }
   }
-});
+);
 
-testPerm({ read: false }, async function readlinkPerm(): Promise<void> {
+unitTest({ perms: { read: false } }, async function readlinkPerm(): Promise<
+  void
+> {
   let caughtError = false;
   try {
     await Deno.readlink("/symlink");