refactor: rewrite testPerm into unitTest (#4231)

Rewrite "testPerm" helper function used for testing of internal 
runtime code. It's been renamed to "unitTest" and provides API that
is extensible in the future by accepting optional "UnitTestOptions" 
argument. "test" helper was also removed and replaced by
overloaded version of "unitTest" that takes only function argument.

"UnitTestOptions" currently supports "perms" and "skip"
options, where former works exactly as first argument to "testPerm"
did, while the latter allows to conditionally skip tests. 

1 files changed, 50 insertions, 39 deletions

diff --git a/cli/js/mkdir_test.ts b/cli/js/mkdir_test.ts
index 655a23dc3..2921177eb 100644
--- a/cli/js/mkdir_test.ts
+++ b/cli/js/mkdir_test.ts
@@ -1,24 +1,30 @@
 // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
-import { testPerm, assert, assertEquals } from "./test_util.ts";
+import { unitTest, assert, assertEquals } from "./test_util.ts";
 
-testPerm({ read: true, write: true }, function mkdirSyncSuccess(): void {
-  const path = Deno.makeTempDirSync() + "/dir";
-  Deno.mkdirSync(path);
-  const pathInfo = Deno.statSync(path);
-  assert(pathInfo.isDirectory());
-});
+unitTest(
+  { perms: { read: true, write: true } },
+  function mkdirSyncSuccess(): void {
+    const path = Deno.makeTempDirSync() + "/dir";
+    Deno.mkdirSync(path);
+    const pathInfo = Deno.statSync(path);
+    assert(pathInfo.isDirectory());
+  }
+);
 
-testPerm({ read: true, write: true }, function mkdirSyncMode(): void {
-  const path = Deno.makeTempDirSync() + "/dir";
-  Deno.mkdirSync(path, { mode: 0o755 }); // no perm for x
-  const pathInfo = Deno.statSync(path);
-  if (pathInfo.mode !== null) {
-    // Skip windows
-    assertEquals(pathInfo.mode & 0o777, 0o755);
+unitTest(
+  { perms: { read: true, write: true } },
+  function mkdirSyncMode(): void {
+    const path = Deno.makeTempDirSync() + "/dir";
+    Deno.mkdirSync(path, { mode: 0o755 }); // no perm for x
+    const pathInfo = Deno.statSync(path);
+    if (pathInfo.mode !== null) {
+      // Skip windows
+      assertEquals(pathInfo.mode & 0o777, 0o755);
+    }
   }
-});
+);
 
-testPerm({ write: false }, function mkdirSyncPerm(): void {
+unitTest({ perms: { write: false } }, function mkdirSyncPerm(): void {
   let err;
   try {
     Deno.mkdirSync("/baddir");
@@ -29,16 +35,17 @@ testPerm({ write: false }, function mkdirSyncPerm(): void {
   assertEquals(err.name, "PermissionDenied");
 });
 
-testPerm({ read: true, write: true }, async function mkdirSuccess(): Promise<
-  void
-> {
-  const path = Deno.makeTempDirSync() + "/dir";
-  await Deno.mkdir(path);
-  const pathInfo = Deno.statSync(path);
-  assert(pathInfo.isDirectory());
-});
+unitTest(
+  { perms: { read: true, write: true } },
+  async function mkdirSuccess(): Promise<void> {
+    const path = Deno.makeTempDirSync() + "/dir";
+    await Deno.mkdir(path);
+    const pathInfo = Deno.statSync(path);
+    assert(pathInfo.isDirectory());
+  }
+);
 
-testPerm({ write: true }, function mkdirErrIfExists(): void {
+unitTest({ perms: { write: true } }, function mkdirErrIfExists(): void {
   let err;
   try {
     Deno.mkdirSync(".");
@@ -48,18 +55,22 @@ testPerm({ write: true }, function mkdirErrIfExists(): void {
   assert(err instanceof Deno.errors.AlreadyExists);
 });
 
-testPerm({ read: true, write: true }, function mkdirSyncRecursive(): void {
-  const path = Deno.makeTempDirSync() + "/nested/directory";
-  Deno.mkdirSync(path, { recursive: true });
-  const pathInfo = Deno.statSync(path);
-  assert(pathInfo.isDirectory());
-});
+unitTest(
+  { perms: { read: true, write: true } },
+  function mkdirSyncRecursive(): void {
+    const path = Deno.makeTempDirSync() + "/nested/directory";
+    Deno.mkdirSync(path, { recursive: true });
+    const pathInfo = Deno.statSync(path);
+    assert(pathInfo.isDirectory());
+  }
+);
 
-testPerm({ read: true, write: true }, async function mkdirRecursive(): Promise<
-  void
-> {
-  const path = Deno.makeTempDirSync() + "/nested/directory";
-  await Deno.mkdir(path, { recursive: true });
-  const pathInfo = Deno.statSync(path);
-  assert(pathInfo.isDirectory());
-});
+unitTest(
+  { perms: { read: true, write: true } },
+  async function mkdirRecursive(): Promise<void> {
+    const path = Deno.makeTempDirSync() + "/nested/directory";
+    await Deno.mkdir(path, { recursive: true });
+    const pathInfo = Deno.statSync(path);
+    assert(pathInfo.isDirectory());
+  }
+);