refactor: rewrite testPerm into unitTest (#4231)

Rewrite "testPerm" helper function used for testing of internal 
runtime code. It's been renamed to "unitTest" and provides API that
is extensible in the future by accepting optional "UnitTestOptions" 
argument. "test" helper was also removed and replaced by
overloaded version of "unitTest" that takes only function argument.

"UnitTestOptions" currently supports "perms" and "skip"
options, where former works exactly as first argument to "testPerm"
did, while the latter allows to conditionally skip tests. 

1 files changed, 15 insertions, 12 deletions

diff --git a/cli/js/metrics_test.ts b/cli/js/metrics_test.ts
index 109cd1a11..5433fc921 100644
--- a/cli/js/metrics_test.ts
+++ b/cli/js/metrics_test.ts
@@ -1,7 +1,7 @@
 // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
-import { test, testPerm, assert } from "./test_util.ts";
+import { unitTest, assert } from "./test_util.ts";
 
-test(async function metrics(): Promise<void> {
+unitTest(async function metrics(): Promise<void> {
   const m1 = Deno.metrics();
   assert(m1.opsDispatched > 0);
   assert(m1.opsDispatchedSync > 0);
@@ -28,19 +28,22 @@ test(async function metrics(): Promise<void> {
   assert(m2.bytesReceived > m1.bytesReceived);
 });
 
-testPerm({ write: true }, function metricsUpdatedIfNoResponseSync(): void {
-  const filename = Deno.makeTempDirSync() + "/test.txt";
+unitTest(
+  { perms: { write: true } },
+  function metricsUpdatedIfNoResponseSync(): void {
+    const filename = Deno.makeTempDirSync() + "/test.txt";
 
-  const data = new Uint8Array([41, 42, 43]);
-  Deno.writeFileSync(filename, data, { perm: 0o666 });
+    const data = new Uint8Array([41, 42, 43]);
+    Deno.writeFileSync(filename, data, { perm: 0o666 });
 
-  const metrics = Deno.metrics();
-  assert(metrics.opsDispatched === metrics.opsCompleted);
-  assert(metrics.opsDispatchedSync === metrics.opsCompletedSync);
-});
+    const metrics = Deno.metrics();
+    assert(metrics.opsDispatched === metrics.opsCompleted);
+    assert(metrics.opsDispatchedSync === metrics.opsCompletedSync);
+  }
+);
 
-testPerm(
-  { write: true },
+unitTest(
+  { perms: { write: true } },
   async function metricsUpdatedIfNoResponseAsync(): Promise<void> {
     const filename = Deno.makeTempDirSync() + "/test.txt";