diff options
author | Nayeem Rahman <nayeemrmn99@gmail.com> | 2023-08-06 00:47:15 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-08-06 01:47:15 +0200 |
commit | c1c8eb3d558bedf6588179ae93737bd6afe5a368 (patch) | |
tree | e6ba4d8aa59a8b73e224fd218cf6e102a81974d9 /cli/js.rs | |
parent | b96f28306490a56aac91b8ef06b35ebdc7f41b63 (diff) |
build: allow disabling snapshots for dev (#20048)
Closes #19399 (running without snapshots at all was suggested as an
alternative solution).
Adds a `__runtime_js_sources` pseudo-private feature to load extension
JS sources at runtime for faster development, instead of building and
loading snapshots or embedding sources in the binary. Will only work in
a development environment obviously.
Try running `cargo test --features __runtime_js_sources
integration::node_unit_tests::os_test`. Then break some behaviour in
`ext/node/polyfills/os.ts` e.g. make `function cpus() {}` return an
empty array, and run it again. Fix and then run again. No more build
time in between.
Diffstat (limited to 'cli/js.rs')
-rw-r--r-- | cli/js.rs | 14 |
1 files changed, 11 insertions, 3 deletions
@@ -3,12 +3,20 @@ use deno_core::Snapshot; use log::debug; +#[cfg(not(feature = "__runtime_js_sources"))] static CLI_SNAPSHOT: &[u8] = include_bytes!(concat!(env!("OUT_DIR"), "/CLI_SNAPSHOT.bin")); -pub fn deno_isolate_init() -> Snapshot { +pub fn deno_isolate_init() -> Option<Snapshot> { debug!("Deno isolate init with snapshots."); - Snapshot::Static(CLI_SNAPSHOT) + #[cfg(not(feature = "__runtime_js_sources"))] + { + Some(Snapshot::Static(CLI_SNAPSHOT)) + } + #[cfg(feature = "__runtime_js_sources")] + { + None + } } #[cfg(test)] @@ -18,7 +26,7 @@ mod tests { #[test] fn runtime_snapshot() { let mut js_runtime = deno_core::JsRuntime::new(deno_core::RuntimeOptions { - startup_snapshot: Some(deno_isolate_init()), + startup_snapshot: deno_isolate_init(), ..Default::default() }); js_runtime |