diff options
author | Marvin Hagemeister <hello@marvinh.dev> | 2023-05-23 12:46:14 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-05-23 12:46:14 +0200 |
commit | 86081052089edbcc2ef2a76ea950ae58f46066b3 (patch) | |
tree | 20761cb520f9076e7b0407677ee0a24329563dcb /cli/graph_util.rs | |
parent | 5874fc3d0aaf1b0453fb916656187503d8619ccd (diff) |
fix(node): duplicate node_module suffixes (#19222)
Noticed that we're checking more module paths than necessary. In
particular the module path array contains a couple of entries with a
duplicated `node_modules/node_modules` suffix.
```js
[
// ... more entries before here, where some also contain duplicate suffixes
"/Users/marvinhagemeister/dev/preact-render-to-string/node_modules/.deno/node_modules",
"/Users/marvinhagemeister/dev/preact-render-to-string/node_modules/node_modules", // <-- duplicate suffix
"/Users/marvinhagemeister/dev/preact-render-to-string/node_modules",
"/Users/marvinhagemeister/dev/node_modules",
"/Users/marvinhagemeister/node_modules",
"/Users/node_modules",
"/node_modules",
"/node_modules" // <-- duplicate entry
]
```
This was caused by a misunderstanding in how Rust's
[`Path::ends_with()`](https://doc.rust-lang.org/std/path/struct.Path.html#method.ends_with)
works. It's designed to match on whole path segments and the suffix
`/node_modules` is not that, except for the root entry. This meant that
our check for if the path already ended with `node_module` always
returned `false`. Removing the leading slash fixes that.
While we're at it, we can remove the last condition where we explicitly
added the root `/node_modules` entry since the while loop prior to that
takes care of it already.
Diffstat (limited to 'cli/graph_util.rs')
0 files changed, 0 insertions, 0 deletions