summaryrefslogtreecommitdiff
path: root/cli/flags.rs
diff options
context:
space:
mode:
authorRyan Dahl <ry@tinyclouds.org>2021-04-26 13:28:38 -0400
committerGitHub <noreply@github.com>2021-04-26 13:28:38 -0400
commitf7c298e2972e6a1eb8f9329272ed8e8c9549266c (patch)
treeed17f90092481db6e5692cff7b3066889541e01e /cli/flags.rs
parente4e7d957e8cde899d48878c83f2099b0028dfdef (diff)
Remove denort optimization (#10350)
denort is an optimization to "deno compile" to produce slightly smaller output. It's a decent idea, but causes a lot of negative side-effects: - Deno's link time is a source of constant agony both locally and in CI, denort doubles link time. - The release process is a long and arduous undertaking with many manual steps. denort necessitates an additional manual zip + upload from M1 apple computers. - The "deno compile" interface is complicated with the "--lite" option. This is confusing for uses ("why wouldn't you want lite?"). The benefits of this feature do not outweigh the negatives. We must find a different approach to optimizing "deno compile" output.
Diffstat (limited to 'cli/flags.rs')
-rw-r--r--cli/flags.rs15
1 files changed, 0 insertions, 15 deletions
diff --git a/cli/flags.rs b/cli/flags.rs
index 3f5e77ff6..0a1ae5ee8 100644
--- a/cli/flags.rs
+++ b/cli/flags.rs
@@ -45,7 +45,6 @@ pub enum DenoSubcommand {
output: Option<PathBuf>,
args: Vec<String>,
target: Option<String>,
- lite: bool,
},
Completions {
buf: Box<[u8]>,
@@ -483,18 +482,12 @@ fn compile_subcommand<'a, 'b>() -> App<'a, 'b> {
.takes_value(true)
.possible_values(&["x86_64-unknown-linux-gnu", "x86_64-pc-windows-msvc", "x86_64-apple-darwin", "aarch64-apple-darwin"])
)
- .arg(
- Arg::with_name("lite")
- .long("lite")
- .help("Use lite runtime")
- )
.about("Compile the script into a self contained executable")
.long_about(
"Compiles the given script into a self contained executable.
deno compile --unstable -A https://deno.land/std/http/file_server.ts
deno compile --unstable --output /usr/local/bin/color_util https://deno.land/std/examples/colors.ts
- deno compile --unstable --lite --target x86_64-unknown-linux-gnu -A https://deno.land/std/http/file_server.ts
Any flags passed which affect runtime behavior, such as '--unstable',
'--allow-*', '--v8-flags', etc. are encoded into the output executable and used
@@ -511,9 +504,6 @@ The executable name is inferred by default:
This commands supports cross-compiling to different target architectures using `--target` flag.
On the first invocation with deno will download proper binary and cache it in $DENO_DIR. The
aarch64-apple-darwin target is not supported in canary.
-
-It is possible to use \"lite\" binaries when compiling by passing `--lite` flag; these are stripped down versions
-of the deno binary that do not contain built-in tooling (eg. formatter, linter). This feature is experimental.
",
)
}
@@ -1444,14 +1434,12 @@ fn compile_parse(flags: &mut Flags, matches: &clap::ArgMatches) {
let args = script.split_off(1);
let source_file = script[0].to_string();
let output = matches.value_of("output").map(PathBuf::from);
- let lite = matches.is_present("lite");
let target = matches.value_of("target").map(String::from);
flags.subcommand = DenoSubcommand::Compile {
source_file,
output,
args,
- lite,
target,
};
}
@@ -3600,7 +3588,6 @@ mod tests {
let r = flags_from_vec(svec![
"deno",
"compile",
- "--lite",
"https://deno.land/std/examples/colors.ts"
]);
assert_eq!(
@@ -3611,7 +3598,6 @@ mod tests {
output: None,
args: vec![],
target: None,
- lite: true,
},
..Flags::default()
}
@@ -3630,7 +3616,6 @@ mod tests {
output: Some(PathBuf::from("colors")),
args: svec!["foo", "bar"],
target: None,
- lite: false,
},
import_map_path: Some("import_map.json".to_string()),
no_remote: true,