summaryrefslogtreecommitdiff
path: root/cli/compilers/mod.rs
diff options
context:
space:
mode:
authorRyan Dahl <ry@tinyclouds.org>2020-02-03 18:08:44 -0500
committerGitHub <noreply@github.com>2020-02-03 18:08:44 -0500
commit161cf7cdfd44ace8937fb7940727984990742d18 (patch)
tree1ef88b3cd6427353366d930ea9be5ae494504255 /cli/compilers/mod.rs
parent0471243334ac1aeb76dcaadbc3f0b8114d188fb8 (diff)
refactor: Use Tokio's single-threaded runtime (#3844)
This change simplifies how we execute V8. Previously V8 Isolates jumped around threads every time they were woken up. This was overly complex and potentially hurting performance in a myriad ways. Now isolates run on their own dedicated thread and never move. - blocking_json spawns a thread and does not use a thread pool - op_host_poll_worker and op_host_resume_worker are non-operational - removes Worker::get_message and Worker::post_message - ThreadSafeState::workers table contains WorkerChannel entries instead of actual Worker instances. - MainWorker and CompilerWorker are no longer Futures. - The multi-threaded version of deno_core_http_bench was removed. - AyncOps no longer need to be Send + Sync This PR is very large and several tests were disabled to speed integration: - installer_test_local_module_run - installer_test_remote_module_run - _015_duplicate_parallel_import - _026_workers
Diffstat (limited to 'cli/compilers/mod.rs')
-rw-r--r--cli/compilers/mod.rs7
1 files changed, 3 insertions, 4 deletions
diff --git a/cli/compilers/mod.rs b/cli/compilers/mod.rs
index a2abbe2aa..f6fc28d37 100644
--- a/cli/compilers/mod.rs
+++ b/cli/compilers/mod.rs
@@ -1,7 +1,7 @@
// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
+use crate::ops::JsonResult;
use deno_core::ErrBox;
use futures::Future;
-use serde_json::Value;
mod compiler_worker;
mod js;
@@ -17,8 +17,7 @@ pub use ts::TargetLib;
pub use ts::TsCompiler;
pub use wasm::WasmCompiler;
-pub type CompilationResultFuture =
- dyn Future<Output = Result<Value, ErrBox>> + Send;
+pub type CompilationResultFuture = dyn Future<Output = JsonResult>;
#[derive(Debug, Clone)]
pub struct CompiledModule {
@@ -27,4 +26,4 @@ pub struct CompiledModule {
}
pub type CompiledModuleFuture =
- dyn Future<Output = Result<CompiledModule, ErrBox>> + Send;
+ dyn Future<Output = Result<CompiledModule, ErrBox>>;