diff options
author | Ryan Dahl <ry@tinyclouds.org> | 2020-02-03 18:08:44 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-02-03 18:08:44 -0500 |
commit | 161cf7cdfd44ace8937fb7940727984990742d18 (patch) | |
tree | 1ef88b3cd6427353366d930ea9be5ae494504255 /cli/compilers/compiler_worker.rs | |
parent | 0471243334ac1aeb76dcaadbc3f0b8114d188fb8 (diff) |
refactor: Use Tokio's single-threaded runtime (#3844)
This change simplifies how we execute V8. Previously V8 Isolates jumped
around threads every time they were woken up. This was overly complex and
potentially hurting performance in a myriad ways. Now isolates run on
their own dedicated thread and never move.
- blocking_json spawns a thread and does not use a thread pool
- op_host_poll_worker and op_host_resume_worker are non-operational
- removes Worker::get_message and Worker::post_message
- ThreadSafeState::workers table contains WorkerChannel entries instead
of actual Worker instances.
- MainWorker and CompilerWorker are no longer Futures.
- The multi-threaded version of deno_core_http_bench was removed.
- AyncOps no longer need to be Send + Sync
This PR is very large and several tests were disabled to speed
integration:
- installer_test_local_module_run
- installer_test_remote_module_run
- _015_duplicate_parallel_import
- _026_workers
Diffstat (limited to 'cli/compilers/compiler_worker.rs')
-rw-r--r-- | cli/compilers/compiler_worker.rs | 43 |
1 files changed, 12 insertions, 31 deletions
diff --git a/cli/compilers/compiler_worker.rs b/cli/compilers/compiler_worker.rs index 99138bcf0..87144c1d0 100644 --- a/cli/compilers/compiler_worker.rs +++ b/cli/compilers/compiler_worker.rs @@ -4,15 +4,9 @@ use crate::state::ThreadSafeState; use crate::worker::Worker; use crate::worker::WorkerChannels; use deno_core; -use deno_core::ErrBox; use deno_core::StartupData; -use futures::future::FutureExt; -use std::future::Future; use std::ops::Deref; use std::ops::DerefMut; -use std::pin::Pin; -use std::task::Context; -use std::task::Poll; /// This worker is used to host TypeScript and WASM compilers. /// @@ -27,7 +21,6 @@ use std::task::Poll; /// /// TODO(bartlomieju): add support to reuse the worker - or in other /// words support stateful TS compiler -#[derive(Clone)] pub struct CompilerWorker(Worker); impl CompilerWorker { @@ -38,27 +31,24 @@ impl CompilerWorker { external_channels: WorkerChannels, ) -> Self { let state_ = state.clone(); - let worker = Worker::new(name, startup_data, state_, external_channels); + let mut worker = Worker::new(name, startup_data, state_, external_channels); { - let mut isolate = worker.isolate.try_lock().unwrap(); - ops::runtime::init(&mut isolate, &state); - ops::compiler::init(&mut isolate, &state); - ops::web_worker::init(&mut isolate, &state); - ops::errors::init(&mut isolate, &state); - + let isolate = &mut worker.isolate; + ops::runtime::init(isolate, &state); + ops::compiler::init(isolate, &state); + ops::web_worker::init(isolate, &state); + ops::errors::init(isolate, &state); // for compatibility with Worker scope, though unused at // the moment - ops::timers::init(&mut isolate, &state); - ops::fetch::init(&mut isolate, &state); - + ops::timers::init(isolate, &state); + ops::fetch::init(isolate, &state); // TODO(bartlomieju): CompilerWorker should not // depend on those ops - ops::os::init(&mut isolate, &state); - ops::files::init(&mut isolate, &state); - ops::fs::init(&mut isolate, &state); - ops::io::init(&mut isolate, &state); + ops::os::init(isolate, &state); + ops::files::init(isolate, &state); + ops::fs::init(isolate, &state); + ops::io::init(isolate, &state); } - Self(worker) } } @@ -75,12 +65,3 @@ impl DerefMut for CompilerWorker { &mut self.0 } } - -impl Future for CompilerWorker { - type Output = Result<(), ErrBox>; - - fn poll(self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> { - let inner = self.get_mut(); - inner.0.poll_unpin(cx) - } -} |