diff options
| author | Geert-Jan Zwiers <geertjanzwiers@protonmail.com> | 2023-01-27 16:16:38 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-27 20:46:38 +0530 |
| commit | 1a1faff2f67613ed0b89e1a34e6c3fd02ca6fd83 (patch) | |
| tree | 71f981c66aa6bf012606ae0654b2dd6c8f0ef563 /cli/cache | |
| parent | 7f38f30a5c0eb06c5b85d1c7ac26a480c210aab6 (diff) | |
chore(cli/cache): fewer string allocations (#17549)
Diffstat (limited to 'cli/cache')
| -rw-r--r-- | cli/cache/check.rs | 2 | ||||
| -rw-r--r-- | cli/cache/incremental.rs | 4 | ||||
| -rw-r--r-- | cli/cache/node.rs | 4 | ||||
| -rw-r--r-- | cli/cache/parsed_source.rs | 4 |
4 files changed, 7 insertions, 7 deletions
diff --git a/cli/cache/check.rs b/cli/cache/check.rs index 2d9acdf51..86fb07577 100644 --- a/cli/cache/check.rs +++ b/cli/cache/check.rs @@ -192,7 +192,7 @@ fn create_tables( |row| row.get(0), ) .ok(); - if data_cli_version != Some(cli_version.to_string()) { + if data_cli_version.as_deref() != Some(&cli_version) { conn.execute("DELETE FROM checkcache", params![])?; conn.execute("DELETE FROM tsbuildinfo", params![])?; let mut stmt = conn diff --git a/cli/cache/incremental.rs b/cli/cache/incremental.rs index 2e838e85a..652965ad7 100644 --- a/cli/cache/incremental.rs +++ b/cli/cache/incremental.rs @@ -232,7 +232,7 @@ impl SqlIncrementalCache { stmt.execute(params![ path.to_string_lossy(), &self.state_hash.to_string(), - &source_hash.to_string(), + &source_hash, ])?; Ok(()) } @@ -267,7 +267,7 @@ fn create_tables( |row| row.get(0), ) .ok(); - if data_cli_version != Some(cli_version.to_string()) { + if data_cli_version.as_deref() != Some(&cli_version) { conn.execute("DELETE FROM incrementalcache", params![])?; let mut stmt = conn .prepare("INSERT OR REPLACE INTO info (key, value) VALUES (?1, ?2)")?; diff --git a/cli/cache/node.rs b/cli/cache/node.rs index 24341e1c1..ec0121c61 100644 --- a/cli/cache/node.rs +++ b/cli/cache/node.rs @@ -253,7 +253,7 @@ impl NodeAnalysisCacheInner { let mut stmt = self.conn.prepare_cached(sql)?; stmt.execute(params![ specifier, - &source_hash.to_string(), + &source_hash, &serde_json::to_string(top_level_decls)?, ])?; Ok(()) @@ -304,7 +304,7 @@ fn create_tables(conn: &Connection, cli_version: &str) -> Result<(), AnyError> { |row| row.get(0), ) .ok(); - if data_cli_version != Some(cli_version.to_string()) { + if data_cli_version.as_deref() != Some(cli_version) { conn.execute("DELETE FROM cjsanalysiscache", params![])?; conn.execute("DELETE FROM esmglobalscache", params![])?; let mut stmt = conn diff --git a/cli/cache/parsed_source.rs b/cli/cache/parsed_source.rs index cef33e354..6385e7384 100644 --- a/cli/cache/parsed_source.rs +++ b/cli/cache/parsed_source.rs @@ -219,7 +219,7 @@ impl ParsedSourceCacheModuleAnalyzer { stmt.execute(params![ specifier.as_str(), &media_type.to_string(), - &source_hash.to_string(), + &source_hash, &serde_json::to_string(&module_info)?, ])?; Ok(()) @@ -298,7 +298,7 @@ fn create_tables( |row| row.get(0), ) .ok(); - if data_cli_version != Some(cli_version.to_string()) { + if data_cli_version.as_deref() != Some(&cli_version) { conn.execute("DELETE FROM moduleinfocache", params![])?; let mut stmt = conn .prepare("INSERT OR REPLACE INTO info (key, value) VALUES (?1, ?2)")?; |