diff options
author | Ryan Dahl <ry@tinyclouds.org> | 2021-04-26 13:28:38 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-04-26 13:28:38 -0400 |
commit | f7c298e2972e6a1eb8f9329272ed8e8c9549266c (patch) | |
tree | ed17f90092481db6e5692cff7b3066889541e01e /cli/bench/main.rs | |
parent | e4e7d957e8cde899d48878c83f2099b0028dfdef (diff) |
Remove denort optimization (#10350)
denort is an optimization to "deno compile" to produce slightly smaller
output. It's a decent idea, but causes a lot of negative side-effects:
- Deno's link time is a source of constant agony both locally and in CI,
denort doubles link time.
- The release process is a long and arduous undertaking with many manual
steps. denort necessitates an additional manual zip + upload from M1
apple computers.
- The "deno compile" interface is complicated with the "--lite" option.
This is confusing for uses ("why wouldn't you want lite?").
The benefits of this feature do not outweigh the negatives. We must find
a different approach to optimizing "deno compile" output.
Diffstat (limited to 'cli/bench/main.rs')
-rw-r--r-- | cli/bench/main.rs | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/cli/bench/main.rs b/cli/bench/main.rs index 8890ec79c..f2ade54d8 100644 --- a/cli/bench/main.rs +++ b/cli/bench/main.rs @@ -228,12 +228,6 @@ fn get_binary_sizes(target_dir: &Path) -> Result<HashMap<String, u64>> { test_util::deno_exe_path().metadata()?.len(), ); - // add up size for denort - sizes.insert( - "denort".to_string(), - test_util::denort_exe_path().metadata()?.len(), - ); - // add up size for everything in target/release/deps/libswc* let swc_size = rlib_size(&target_dir, "libswc"); println!("swc {} bytes", swc_size); |