diff options
| author | HasanAlrimawi <141642411+HasanAlrimawi@users.noreply.github.com> | 2024-08-27 14:45:27 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-27 13:45:27 +0200 |
| commit | 672ce3041a3dd9e2a6aab5f0ef79ec2be9cf1cba (patch) | |
| tree | 4ae58965c192806280c7c9711d5764a6377db0df /cli/args | |
| parent | 7e68cce8159d55fd597f0da3e00f794200b9928f (diff) | |
fix: removed unstable-htttp from deno help (#25216)
Closes #25210 .
Removed --unstable-http from being displayed on deno run --help=unstable
---------
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Diffstat (limited to 'cli/args')
| -rw-r--r-- | cli/args/flags.rs | 30 | ||||
| -rw-r--r-- | cli/args/mod.rs | 2 |
2 files changed, 20 insertions, 12 deletions
diff --git a/cli/args/flags.rs b/cli/args/flags.rs index de6358359..877b26de2 100644 --- a/cli/args/flags.rs +++ b/cli/args/flags.rs @@ -4042,18 +4042,23 @@ impl Iterator for UnstableArgsIter { }) .help_heading(UNSTABLE_HEADING) } else if self.idx > 3 { - let (flag_name, help, _) = - crate::UNSTABLE_GRANULAR_FLAGS.get(self.idx - 4)?; - Arg::new(format!("unstable-{}", flag_name)) - .long(format!("unstable-{}", flag_name)) - .help(help) + let granular_flag = crate::UNSTABLE_GRANULAR_FLAGS.get(self.idx - 4)?; + Arg::new(format!("unstable-{}", granular_flag.name)) + .long(format!("unstable-{}", granular_flag.name)) + .help(granular_flag.help_text) .action(ArgAction::SetTrue) .hide(true) .help_heading(UNSTABLE_HEADING) // we don't render long help, so using it here as a sort of metadata - .long_help(match self.cfg { - UnstableArgsConfig::None | UnstableArgsConfig::ResolutionOnly => None, - UnstableArgsConfig::ResolutionAndRuntime => Some("true"), + .long_help(if granular_flag.show_in_help { + match self.cfg { + UnstableArgsConfig::None | UnstableArgsConfig::ResolutionOnly => { + None + } + UnstableArgsConfig::ResolutionAndRuntime => Some("true"), + } + } else { + None }) } else { return None; @@ -5405,9 +5410,12 @@ fn unstable_args_parse( matches.get_flag("unstable-sloppy-imports"); if matches!(cfg, UnstableArgsConfig::ResolutionAndRuntime) { - for (name, _, _) in crate::UNSTABLE_GRANULAR_FLAGS { - if matches.get_flag(&format!("unstable-{}", name)) { - flags.unstable_config.features.push(name.to_string()); + for granular_flag in crate::UNSTABLE_GRANULAR_FLAGS { + if matches.get_flag(&format!("unstable-{}", granular_flag.name)) { + flags + .unstable_config + .features + .push(granular_flag.name.to_string()); } } } diff --git a/cli/args/mod.rs b/cli/args/mod.rs index 056dcb2af..a6b547fd7 100644 --- a/cli/args/mod.rs +++ b/cli/args/mod.rs @@ -1669,7 +1669,7 @@ impl CliOptions { let mut all_valid_unstable_flags: Vec<&str> = crate::UNSTABLE_GRANULAR_FLAGS .iter() - .map(|granular_flag| granular_flag.0) + .map(|granular_flag| granular_flag.name) .collect(); let mut another_unstable_flags = Vec::from([ |