summaryrefslogtreecommitdiff
path: root/bench_util/src/js_runtime.rs
diff options
context:
space:
mode:
authorBartek IwaƄczuk <biwanczuk@gmail.com>2021-04-28 18:28:46 +0200
committerGitHub <noreply@github.com>2021-04-28 18:28:46 +0200
commitb28f9445aae85dbf86033300cfcb55e404529a23 (patch)
tree65b89f43a2af1984b3e1c49f281bd8aba8138089 /bench_util/src/js_runtime.rs
parent6a33d2073f1a99d0943a986418a376386fdc30b3 (diff)
refactor(core): simplify module loading code (#10385)
General cleanup of module loading code, tried to reduce indentation in various methods on "JsRuntime" to improve readability. Added "JsRuntime::handle_scope" helper function, which returns a "v8::HandleScope". This was done to reduce a code pattern that happens all over the "deno_core". Additionally if event loop hangs during loading of dynamic modules a list of currently pending dynamic imports is printed.
Diffstat (limited to 'bench_util/src/js_runtime.rs')
-rw-r--r--bench_util/src/js_runtime.rs3
1 files changed, 1 insertions, 2 deletions
diff --git a/bench_util/src/js_runtime.rs b/bench_util/src/js_runtime.rs
index d5509d624..0752e2097 100644
--- a/bench_util/src/js_runtime.rs
+++ b/bench_util/src/js_runtime.rs
@@ -31,8 +31,7 @@ pub fn bench_js_sync(
setup: impl FnOnce(&mut JsRuntime),
) {
let mut runtime = create_js_runtime(setup);
- let context = runtime.global_context();
- let scope = &mut v8::HandleScope::with_context(runtime.v8_isolate(), context);
+ let scope = &mut runtime.handle_scope();
// Increase JS iterations if profiling for nicer flamegraphs
let inner_iters = 1000 * if is_profiling() { 10000 } else { 1 };