diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2023-12-29 22:15:22 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-12-29 21:15:22 +0000 |
commit | fa3a12a8056836e7ab337c4af1eabcb0e8edade2 (patch) | |
tree | 019cbe7f7c0ce8dfd34a8521fd3abdd969e42ef0 | |
parent | 1dd1aba2448c6c8a5a0370c4066a68aca06b859b (diff) |
chore: disable PTR_HOST dns test for Node compat (#21735)
These tests started failing on CI on Dec 28th, 2023 returning
ENOTFOUND. It's unclear what's going on, since `dig -x
8.8.8.8.in-addr.arpa`.
It needs a deeper investigation, but I want to unblock main branch
in the meantime.
-rw-r--r-- | cli/tests/node_compat/test/internet/test-dns-any.js | 38 | ||||
-rw-r--r-- | cli/tests/node_compat/test/internet/test-dns.js | 35 |
2 files changed, 39 insertions, 34 deletions
diff --git a/cli/tests/node_compat/test/internet/test-dns-any.js b/cli/tests/node_compat/test/internet/test-dns-any.js index cd4450524..b8a70b8e2 100644 --- a/cli/tests/node_compat/test/internet/test-dns-any.js +++ b/cli/tests/node_compat/test/internet/test-dns-any.js @@ -172,21 +172,23 @@ TEST(async function test_google_for_cname_and_srv(done) { checkWrap(req); }); -TEST(async function test_ptr(done) { - function validateResult(res) { - const types = processResult(res); - assert.ok(types.PTR); - } - - validateResult(await dnsPromises.resolve('8.8.8.8.in-addr.arpa', 'ANY')); - - const req = dns.resolve( - '8.8.8.8.in-addr.arpa', - 'ANY', - common.mustSucceed((ret) => { - validateResult(ret); - done(); - })); - - checkWrap(req); -}); +// TODO(bartlomieju): this test started failing on CI on Dec 28th, 2023 returning +// ENOTFOUND. It's unclear what's going on, since `dig -x 8.8.8.8.in-addr.arpa` +// TEST(async function test_ptr(done) { +// function validateResult(res) { +// const types = processResult(res); +// assert.ok(types.PTR); +// } + +// validateResult(await dnsPromises.resolve('8.8.8.8.in-addr.arpa', 'ANY')); + +// const req = dns.resolve( +// '8.8.8.8.in-addr.arpa', +// 'ANY', +// common.mustSucceed((ret) => { +// validateResult(ret); +// done(); +// })); + +// checkWrap(req); +// }); diff --git a/cli/tests/node_compat/test/internet/test-dns.js b/cli/tests/node_compat/test/internet/test-dns.js index 26c114fd5..8aaeb728d 100644 --- a/cli/tests/node_compat/test/internet/test-dns.js +++ b/cli/tests/node_compat/test/internet/test-dns.js @@ -281,26 +281,29 @@ TEST(async function test_resolveSrv(done) { // checkWrap(req); // }); -TEST(async function test_resolvePtr(done) { - function validateResult(result) { - assert.ok(result.length > 0); +// TODO(bartlomieju): this test started failing on CI on Dec 28th, 2023 returning +// ENOTFOUND. It's unclear what's going on, since `dig -x 8.8.8.8.in-addr.arpa` +// returns correct PTR record. +// TEST(async function test_resolvePtr(done) { +// function validateResult(result) { +// assert.ok(result.length > 0); - for (const item of result) { - assert.ok(item); - assert.strictEqual(typeof item, 'string'); - } - } +// for (const item of result) { +// assert.ok(item); +// assert.strictEqual(typeof item, 'string'); +// } +// } - validateResult(await dnsPromises.resolvePtr(addresses.PTR_HOST)); +// validateResult(await dnsPromises.resolvePtr(addresses.PTR_HOST)); - const req = dns.resolvePtr(addresses.PTR_HOST, function(err, result) { - assert.ifError(err); - validateResult(result); - done(); - }); +// const req = dns.resolvePtr(addresses.PTR_HOST, function(err, result) { +// assert.ifError(err); +// validateResult(result); +// done(); +// }); - checkWrap(req); -}); +// checkWrap(req); +// }); // TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN` // instead of `ENOTFOUND`. |