summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBartek IwaƄczuk <biwanczuk@gmail.com>2022-12-14 00:54:11 +0100
committerGitHub <noreply@github.com>2022-12-14 00:54:11 +0100
commitf9db129bdf1e09f6d5faaa73ad0cad27d2418798 (patch)
treeffbdd7dd703e6478b8e24f01f9917ba9705365d1
parent392cca87a80951eef32c96a127d73ebe33a9e117 (diff)
feat: Stabilize Deno.TcpConn.setNoDelay() and Deno.TcpConn.setKeepAlive() (#17003)
This commit stabilizes following APIs: - `Deno.TcpConn.setNoDelay()` - `Deno.TcpConn.setKeepAlive()`
-rw-r--r--ext/net/01_net.js8
-rw-r--r--ext/net/lib.deno_net.d.ts14
-rw-r--r--ext/net/ops.rs2
-rw-r--r--ops/optimizer_tests/unit_result2.out1
-rw-r--r--ops/optimizer_tests/unit_result2.rs1
5 files changed, 8 insertions, 18 deletions
diff --git a/ext/net/01_net.js b/ext/net/01_net.js
index 971ec2e8b..f25904e80 100644
--- a/ext/net/01_net.js
+++ b/ext/net/01_net.js
@@ -100,12 +100,12 @@
}
class TcpConn extends Conn {
- setNoDelay(nodelay = true) {
- return ops.op_set_nodelay(this.rid, nodelay);
+ setNoDelay(noDelay = true) {
+ return ops.op_set_nodelay(this.rid, noDelay);
}
- setKeepAlive(keepalive = true) {
- return ops.op_set_keepalive(this.rid, keepalive);
+ setKeepAlive(keepAlive = true) {
+ return ops.op_set_keepalive(this.rid, keepAlive);
}
}
diff --git a/ext/net/lib.deno_net.d.ts b/ext/net/lib.deno_net.d.ts
index e8dd5a957..639d0f8af 100644
--- a/ext/net/lib.deno_net.d.ts
+++ b/ext/net/lib.deno_net.d.ts
@@ -185,19 +185,13 @@ declare namespace Deno {
/** @category Network */
export interface TcpConn extends Conn {
/**
- * **UNSTABLE**: new API, see https://github.com/denoland/deno/issues/13617.
- *
* Enable/disable the use of Nagle's algorithm.
*
- * @param [nodelay=true]
- */
- setNoDelay(nodelay?: boolean): void;
- /**
- * **UNSTABLE**: new API, see https://github.com/denoland/deno/issues/13617.
- *
- * Enable/disable keep-alive functionality.
+ * @param [noDelay=true]
*/
- setKeepAlive(keepalive?: boolean): void;
+ setNoDelay(noDelay?: boolean): void;
+ /** Enable/disable keep-alive functionality. */
+ setKeepAlive(keepAlive?: boolean): void;
}
/** @category Network */
diff --git a/ext/net/ops.rs b/ext/net/ops.rs
index e567c3188..48db79745 100644
--- a/ext/net/ops.rs
+++ b/ext/net/ops.rs
@@ -514,7 +514,6 @@ pub fn op_set_nodelay(
rid: ResourceId,
nodelay: bool,
) -> Result<(), AnyError> {
- super::check_unstable(state, "Deno.Conn#setNoDelay");
let resource: Rc<TcpStreamResource> =
state.resource_table.get::<TcpStreamResource>(rid)?;
resource.set_nodelay(nodelay)
@@ -526,7 +525,6 @@ pub fn op_set_keepalive(
rid: ResourceId,
keepalive: bool,
) -> Result<(), AnyError> {
- super::check_unstable(state, "Deno.Conn#setKeepAlive");
let resource: Rc<TcpStreamResource> =
state.resource_table.get::<TcpStreamResource>(rid)?;
resource.set_keepalive(keepalive)
diff --git a/ops/optimizer_tests/unit_result2.out b/ops/optimizer_tests/unit_result2.out
index 87e0ee0b5..e297befcb 100644
--- a/ops/optimizer_tests/unit_result2.out
+++ b/ops/optimizer_tests/unit_result2.out
@@ -36,7 +36,6 @@ impl op_set_nodelay {
rid: ResourceId,
nodelay: bool,
) -> Result<(), AnyError> {
- super::check_unstable(state, "Deno.Conn#setNoDelay");
let resource: Rc<TcpStreamResource> = state
.resource_table
.get::<TcpStreamResource>(rid)?;
diff --git a/ops/optimizer_tests/unit_result2.rs b/ops/optimizer_tests/unit_result2.rs
index d3e8ced6a..83b73e194 100644
--- a/ops/optimizer_tests/unit_result2.rs
+++ b/ops/optimizer_tests/unit_result2.rs
@@ -3,7 +3,6 @@ pub fn op_set_nodelay(
rid: ResourceId,
nodelay: bool,
) -> Result<(), AnyError> {
- super::check_unstable(state, "Deno.Conn#setNoDelay");
let resource: Rc<TcpStreamResource> =
state.resource_table.get::<TcpStreamResource>(rid)?;
resource.set_nodelay(nodelay)