summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAsher Gomez <ashersaupingomez@gmail.com>2024-02-23 11:17:39 +1100
committerGitHub <noreply@github.com>2024-02-23 00:17:39 +0000
commitf7b08cd962aeaf6f727c2c9f54296a464ea1a839 (patch)
tree4027577b76ce492fe1b3169daeb177bc55719a35
parente8b192517275e90a262d68a02fb038eccfad8877 (diff)
chore: fail properly in web platform test (#22549)
Having `|| true` means that the job always executes with a success code, even when it really fails. Credit to Bartek for spotting this possible mistake. Towards #22257
-rw-r--r--.github/workflows/wpt_epoch.yml2
1 files changed, 1 insertions, 1 deletions
diff --git a/.github/workflows/wpt_epoch.yml b/.github/workflows/wpt_epoch.yml
index ab4a2ec4d..cac5c9a46 100644
--- a/.github/workflows/wpt_epoch.yml
+++ b/.github/workflows/wpt_epoch.yml
@@ -72,7 +72,7 @@ jobs:
deno run --unstable --allow-write --allow-read --allow-net \
--allow-env --allow-run --lock=tools/deno.lock.json \
./tools/wpt.ts run \
- --binary=$(which deno) --quiet --release --no-ignore --json=wpt.json --wptreport=wptreport.json || true
+ --binary=$(which deno) --quiet --release --no-ignore --json=wpt.json --wptreport=wptreport.json
- name: Upload wpt results to wpt.fyi
env: