diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2022-07-30 11:43:03 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-07-30 11:43:03 -0400 |
| commit | ef5653be9823065e14189e412b52296bc4aeecb9 (patch) | |
| tree | 2d5dd88b4d71fbe45cdd7587430c657050f52977 | |
| parent | 20a89d46c4af091f30daf0df20b12c91962f9b14 (diff) | |
refactor: reuse `FastInsecureHasher` in `get_check_hash` (#15354)
| -rw-r--r-- | cli/cache/common.rs | 5 | ||||
| -rw-r--r-- | cli/emit.rs | 10 |
2 files changed, 8 insertions, 7 deletions
diff --git a/cli/cache/common.rs b/cli/cache/common.rs index b536d6cb2..d1578ce8d 100644 --- a/cli/cache/common.rs +++ b/cli/cache/common.rs @@ -24,6 +24,11 @@ impl FastInsecureHasher { self } + pub fn write_u8(&mut self, value: u8) -> &mut Self { + self.0.write_u8(value); + self + } + pub fn write_u64(&mut self, value: u64) -> &mut Self { self.0.write_u64(value); self diff --git a/cli/emit.rs b/cli/emit.rs index 0ba7ccf08..4c347a09c 100644 --- a/cli/emit.rs +++ b/cli/emit.rs @@ -382,11 +382,7 @@ fn get_check_hash( graph_data: &GraphData, options: &CheckOptions, ) -> CheckHashResult { - // twox hash is insecure, but fast so it works for our purposes - use std::hash::Hasher; - use twox_hash::XxHash64; - - let mut hasher = XxHash64::default(); + let mut hasher = FastInsecureHasher::new(); hasher.write_u8(match options.type_check_mode { TypeCheckMode::All => 0, TypeCheckMode::Local => 1, @@ -437,8 +433,8 @@ fn get_check_hash( | MediaType::Wasm | MediaType::Unknown => continue, } - hasher.write(specifier.as_str().as_bytes()); - hasher.write(code.as_bytes()); + hasher.write_str(specifier.as_str()); + hasher.write_str(code); } } |