diff options
| author | Bert Belder <bertbelder@gmail.com> | 2022-01-26 14:18:19 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-01-26 14:18:19 -0800 |
| commit | dcf8f144ab0516936bfa4e93357d71f1732d880e (patch) | |
| tree | 03385ceb6005655278c8f5bb7fc718005c4d6b01 | |
| parent | 380ebbd6d55f8933f614c405ee1050f7231d7ed4 (diff) | |
Revert "error on warnings (#13344)" (#13502)
The reverted PR had the unintentional side effect of disabling static linking on Windows.
See https://github.com/denoland/deno/issues/13471.
This reverts commit 79b698f88b5f8e247df7280ccb52c2a8271a426c.
| -rw-r--r-- | .github/workflows/ci.yml | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1312e8ea9..0cc3ab748 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -53,7 +53,6 @@ jobs: CARGO_TERM_COLOR: always RUST_BACKTRACE: full RUSTC_FORCE_INCREMENTAL: 1 - RUSTFLAGS: -D warnings steps: - name: Configure git @@ -144,6 +143,11 @@ jobs: service_account_key: ${{ secrets.GCP_SA_KEY }} export_default_credentials: true + - name: Error on warning + # TODO(piscisaureus): enable this on Windows again. + if: "!matrix.use_sysroot && !startsWith(matrix.os, 'windows')" + run: echo "RUSTFLAGS=-D warnings" >> $GITHUB_ENV + - name: Configure canary build if: | matrix.job == 'test' && |