diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2024-02-20 13:39:03 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-20 13:39:03 -0500 |
| commit | dbc4a4d6327062918b3bc41dc3f60c84ae3c620b (patch) | |
| tree | 054b8e160a8ebf6a57b6772273414c98ac0fe2fc | |
| parent | 4201f17936e6c67eaf2d7b0d76690f674d68d13e (diff) | |
chore: fix flaky lsp_vendor_dir (#22483)
I think it was occassionally reading the diagnostics from the previous
cache command rather than the config update.
Closes #22481
| -rw-r--r-- | tests/integration/lsp_tests.rs | 4 | ||||
| -rw-r--r-- | tests/util/server/src/lsp.rs | 2 |
2 files changed, 5 insertions, 1 deletions
diff --git a/tests/integration/lsp_tests.rs b/tests/integration/lsp_tests.rs index 97e9215df..34ea7362c 100644 --- a/tests/integration/lsp_tests.rs +++ b/tests/integration/lsp_tests.rs @@ -10666,6 +10666,10 @@ fn lsp_vendor_dir() { assert!(!temp_dir.path().join("vendor").exists()); + // read the diagnostic update after caching + let diagnostics = client.read_diagnostics(); + assert_eq!(diagnostics.all().len(), 0); + temp_dir.write( temp_dir.path().join("deno.json"), "{ \"vendor\": true, \"lock\": false }\n", diff --git a/tests/util/server/src/lsp.rs b/tests/util/server/src/lsp.rs index 6b8256fc1..cc6808390 100644 --- a/tests/util/server/src/lsp.rs +++ b/tests/util/server/src/lsp.rs @@ -799,7 +799,7 @@ impl LspClient { result.as_u64().unwrap() as usize } - /// Reads the latest diagnostics. It's assumed that + /// Reads the latest diagnostics. pub fn read_diagnostics(&mut self) -> CollectedDiagnostics { // wait for three (deno, lint, and typescript diagnostics) batch // notification messages for that index |