summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBartek IwaƄczuk <biwanczuk@gmail.com>2023-10-09 10:57:32 +0200
committerGitHub <noreply@github.com>2023-10-09 17:57:32 +0900
commitd868bae90a5437c75c52ac831c59030120cfdc88 (patch)
tree86472b6cb694ce0caf5ce91050eafeef3a137e67
parentae81065c758a540aa61639e51372c1e254d92c9a (diff)
chore: disable flaky Node compat test (#20832)
-rw-r--r--cli/tests/node_compat/test/internet/test-dns.js30
1 files changed, 16 insertions, 14 deletions
diff --git a/cli/tests/node_compat/test/internet/test-dns.js b/cli/tests/node_compat/test/internet/test-dns.js
index 9741db8e6..986bb0d3f 100644
--- a/cli/tests/node_compat/test/internet/test-dns.js
+++ b/cli/tests/node_compat/test/internet/test-dns.js
@@ -172,24 +172,26 @@ TEST(async function test_resolveMx(done) {
checkWrap(req);
});
-TEST(function test_resolveMx_failure(done) {
- dnsPromises.resolveMx(addresses.NOT_FOUND)
- .then(common.mustNotCall())
- .catch(common.mustCall((err) => {
- assert.strictEqual(err.code, 'ENOTFOUND');
- }));
+// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
+// instead of `ENOTFOUND`.
+// TEST(function test_resolveMx_failure(done) {
+// dnsPromises.resolveMx(addresses.NOT_FOUND)
+// .then(common.mustNotCall())
+// .catch(common.mustCall((err) => {
+// assert.strictEqual(err.code, 'ENOTFOUND');
+// }));
- const req = dns.resolveMx(addresses.NOT_FOUND, function(err, result) {
- assert.ok(err instanceof Error);
- assert.strictEqual(err.code, 'ENOTFOUND');
+// const req = dns.resolveMx(addresses.NOT_FOUND, function(err, result) {
+// assert.ok(err instanceof Error);
+// assert.strictEqual(err.code, 'ENOTFOUND');
- assert.strictEqual(result, undefined);
+// assert.strictEqual(result, undefined);
- done();
- });
+// done();
+// });
- checkWrap(req);
-});
+// checkWrap(req);
+// });
TEST(async function test_resolveNs(done) {
function validateResult(result) {