diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2022-08-09 17:28:13 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-09 17:28:13 -0400 |
| commit | d6f789eb05e18dd8887e8e409736773bdf2e0e00 (patch) | |
| tree | f0773fb4027dbd62a20917411d06805c88df5ecf | |
| parent | 1c2ec1f48f2cf9255f0a43f2ec3d15aeee081b33 (diff) | |
chore: temporarily disable `op_require_read_file` (#15433)
| -rw-r--r-- | cli/tests/integration/compat_tests.rs | 1 | ||||
| -rw-r--r-- | ext/node/01_require.js | 2 | ||||
| -rw-r--r-- | ext/node/lib.rs | 5 |
3 files changed, 4 insertions, 4 deletions
diff --git a/cli/tests/integration/compat_tests.rs b/cli/tests/integration/compat_tests.rs index e8e6316bf..88514832f 100644 --- a/cli/tests/integration/compat_tests.rs +++ b/cli/tests/integration/compat_tests.rs @@ -173,6 +173,7 @@ fn native_modules_as_global_vars() { assert!(out.contains("true")); } +#[ignore] // todo(dsherret): re-enable #[test] fn ext_node_cjs_execution() { let (out, _err) = util::run_and_collect_output_with_args( diff --git a/ext/node/01_require.js b/ext/node/01_require.js index 5a29617b1..7b89e9dc3 100644 --- a/ext/node/01_require.js +++ b/ext/node/01_require.js @@ -476,7 +476,7 @@ if (typeof options === "object" && options !== null) { if (ArrayIsArray(options.paths)) { const isRelative = core.opSync( - "op_require_specifier_is_relative", + "op_require_is_request_relative", request, ); diff --git a/ext/node/lib.rs b/ext/node/lib.rs index 5d6542dc5..80296a6cc 100644 --- a/ext/node/lib.rs +++ b/ext/node/lib.rs @@ -311,7 +311,6 @@ fn op_require_try_self( } #[op] -fn op_require_read_file(filename: String) -> Result<String, AnyError> { - let contents = std::fs::read_to_string(filename)?; - Ok(contents) +fn op_require_read_file(_filename: String) -> Result<String, AnyError> { + todo!("not implemented"); } |