diff options
| author | Divy Srivastava <dj.srivastava23@gmail.com> | 2024-09-15 11:29:24 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-15 11:29:24 +0530 |
| commit | a666c8c9f92d87e7a3b4d4e06fdc027b3bf9663e (patch) | |
| tree | 2d0b8f74dbf8a56bf5c0e2c5750a16a56583fab3 | |
| parent | db6fc12b9e2d5cb55c1f3c61b054805505ae11a6 (diff) | |
fix(cli): `deno task` exit with status 0 (#25637)
Fixes https://github.com/denoland/deno/issues/25632
Exit code 1 indiciates some sort of failure but `deno task` (without
arguments) is used to list available commands.
---------
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
| -rw-r--r-- | cli/tools/task.rs | 2 | ||||
| -rw-r--r-- | tests/specs/task/both_no_arg/__test__.jsonc | 2 | ||||
| -rw-r--r-- | tests/specs/task/cwd_resolves_config_from_specified_dir/__test__.jsonc | 2 | ||||
| -rw-r--r-- | tests/specs/task/doc_comments_no_args/__test__.jsonc | 2 | ||||
| -rw-r--r-- | tests/specs/task/no_args/__test__.jsonc | 2 | ||||
| -rw-r--r-- | tests/specs/task/package_json_no_arg/__test__.jsonc | 2 | ||||
| -rw-r--r-- | tests/specs/task/workspace/__test__.jsonc | 8 |
7 files changed, 10 insertions, 10 deletions
diff --git a/cli/tools/task.rs b/cli/tools/task.rs index cc16bb9a3..e806d586c 100644 --- a/cli/tools/task.rs +++ b/cli/tools/task.rs @@ -75,7 +75,7 @@ See https://docs.deno.com/go/config"# &cli_options.start_dir, &tasks_config, )?; - return Ok(1); + return Ok(0); } }; diff --git a/tests/specs/task/both_no_arg/__test__.jsonc b/tests/specs/task/both_no_arg/__test__.jsonc index c80db130e..7f60fcf36 100644 --- a/tests/specs/task/both_no_arg/__test__.jsonc +++ b/tests/specs/task/both_no_arg/__test__.jsonc @@ -4,5 +4,5 @@ "envs": { "NO_COLOR": "1" }, - "exitCode": 1 + "exitCode": 0 } diff --git a/tests/specs/task/cwd_resolves_config_from_specified_dir/__test__.jsonc b/tests/specs/task/cwd_resolves_config_from_specified_dir/__test__.jsonc index 97898e14f..d8ba8d97f 100644 --- a/tests/specs/task/cwd_resolves_config_from_specified_dir/__test__.jsonc +++ b/tests/specs/task/cwd_resolves_config_from_specified_dir/__test__.jsonc @@ -4,5 +4,5 @@ "envs": { "NO_COLOR": "1" }, - "exitCode": 1 + "exitCode": 0 } diff --git a/tests/specs/task/doc_comments_no_args/__test__.jsonc b/tests/specs/task/doc_comments_no_args/__test__.jsonc index 2f9db088a..9843fa5ab 100644 --- a/tests/specs/task/doc_comments_no_args/__test__.jsonc +++ b/tests/specs/task/doc_comments_no_args/__test__.jsonc @@ -2,5 +2,5 @@ "args": "task", "envs": { "NO_COLOR": "1" }, "output": "task.out", - "exitCode": 1 + "exitCode": 0 } diff --git a/tests/specs/task/no_args/__test__.jsonc b/tests/specs/task/no_args/__test__.jsonc index 9ec24d1d2..6347c5989 100644 --- a/tests/specs/task/no_args/__test__.jsonc +++ b/tests/specs/task/no_args/__test__.jsonc @@ -4,5 +4,5 @@ "envs": { "NO_COLOR": "1" }, - "exitCode": 1 + "exitCode": 0 } diff --git a/tests/specs/task/package_json_no_arg/__test__.jsonc b/tests/specs/task/package_json_no_arg/__test__.jsonc index 2d7b75a2f..4ee627dd2 100644 --- a/tests/specs/task/package_json_no_arg/__test__.jsonc +++ b/tests/specs/task/package_json_no_arg/__test__.jsonc @@ -4,5 +4,5 @@ "envs": { "NO_COLOR": "1" }, - "exitCode": 1 + "exitCode": 0 } diff --git a/tests/specs/task/workspace/__test__.jsonc b/tests/specs/task/workspace/__test__.jsonc index b08f35afc..5a3ad1356 100644 --- a/tests/specs/task/workspace/__test__.jsonc +++ b/tests/specs/task/workspace/__test__.jsonc @@ -3,25 +3,25 @@ "root": { "args": "task", "output": "root.out", - "exitCode": 1 + "exitCode": 0 }, "package_a": { "args": "task", "cwd": "package-a", "output": "package-a.out", - "exitCode": 1 + "exitCode": 0 }, "package_b": { "args": "task", "cwd": "package-b", "output": "package-b.out", - "exitCode": 1 + "exitCode": 0 }, "scripts": { "args": "task", "cwd": "scripts", "output": "scripts.out", - "exitCode": 1 + "exitCode": 0 }, "package_b_tasks": { "steps": [{ |