diff options
| author | Asher Gomez <ashersaupingomez@gmail.com> | 2024-04-07 17:46:39 +1000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-07 17:46:39 +1000 |
| commit | 9b34b7ed1862c4b7bd84d52cd3417f5a1592efc4 (patch) | |
| tree | 053c752de10b8578fa4b4188106cb2a1e3e6635f | |
| parent | d3f3e0d717fdbbf531fde0c9e7259f6bb887fa10 (diff) | |
FUTURE(ext/fs): remove `Deno.FsWatcher.prototype.rid` (#23234)
| -rw-r--r-- | runtime/js/40_fs_events.js | 7 | ||||
| -rw-r--r-- | tests/specs/future/runtime_api/main.js | 4 | ||||
| -rw-r--r-- | tests/specs/future/runtime_api/main.out | 1 |
3 files changed, 12 insertions, 0 deletions
diff --git a/runtime/js/40_fs_events.js b/runtime/js/40_fs_events.js index 3493ddcd9..d7aa5de05 100644 --- a/runtime/js/40_fs_events.js +++ b/runtime/js/40_fs_events.js @@ -11,6 +11,7 @@ const { ObjectPrototypeIsPrototypeOf, PromiseResolve, SymbolAsyncIterator, + ObjectDefineProperty, } = primordials; import { SymbolDispose } from "ext:deno_web/00_infra.js"; @@ -20,6 +21,12 @@ class FsWatcher { #promise; constructor(paths, options) { + if (internals.future) { + ObjectDefineProperty(this, "rid", { + enumerable: false, + value: undefined, + }); + } const { recursive } = options; this.#rid = op_fs_events_open({ recursive, paths }); } diff --git a/tests/specs/future/runtime_api/main.js b/tests/specs/future/runtime_api/main.js index 9d3b3ed6c..db8e5fba8 100644 --- a/tests/specs/future/runtime_api/main.js +++ b/tests/specs/future/runtime_api/main.js @@ -31,6 +31,10 @@ console.log("Deno.writeAllSync is", Deno.writeAllSync); console.log("Deno.write is", Deno.write); console.log("Deno.writeSync is", Deno.writeSync); +const watcher = Deno.watchFs("."); +console.log("Deno.FsWatcher.prototype.rid is", watcher.rid); +watcher.close(); + try { new Deno.FsFile(0); } catch (error) { diff --git a/tests/specs/future/runtime_api/main.out b/tests/specs/future/runtime_api/main.out index 595ffd4a4..252e33512 100644 --- a/tests/specs/future/runtime_api/main.out +++ b/tests/specs/future/runtime_api/main.out @@ -27,4 +27,5 @@ Deno.writeAll is undefined Deno.writeAllSync is undefined Deno.write is undefined Deno.writeSync is undefined +Deno.FsWatcher.prototype.rid is undefined Deno.FsFile constructor is illegal |
