summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRyan Dahl <ry@tinyclouds.org>2019-03-18 21:24:12 -0400
committerRyan Dahl <ry@tinyclouds.org>2019-03-19 03:50:47 -0400
commit8f3d0ca6649236434ee7a795f5a2cea114d44847 (patch)
tree354ebf022b82534795a5fb7d8ea5c78e0ed4bb01
parentcdfd32dd74d6286afe99fb5400e3dc0e9f2cec49 (diff)
Deprecate DENO_BUILD_MODE=release
Instead use: tools/build.py --release
-rwxr-xr-xtools/build.py13
-rw-r--r--website/manual.md5
2 files changed, 14 insertions, 4 deletions
diff --git a/tools/build.py b/tools/build.py
index e66f1f094..82426f5b2 100755
--- a/tools/build.py
+++ b/tools/build.py
@@ -1,16 +1,27 @@
#!/usr/bin/env python
# Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
from __future__ import print_function
+import argparse
import os
import sys
import third_party
from util import build_path, enable_ansi_colors, run
+parser = argparse.ArgumentParser()
+parser.add_argument(
+ "--release", help="Use target/release", action="store_true")
+
def main(argv):
enable_ansi_colors()
- ninja_args = argv[1:]
+ args, rest_argv = parser.parse_known_args(argv)
+
+ if "DENO_BUILD_MODE" not in os.environ:
+ if args.release:
+ os.environ["DENO_BUILD_MODE"] = "release"
+
+ ninja_args = rest_argv[1:]
if not "-C" in ninja_args:
if not os.path.isdir(build_path()):
print("Build directory '%s' does not exist." % build_path(),
diff --git a/website/manual.md b/website/manual.md
index e5104e605..8d0dacabc 100644
--- a/website/manual.md
+++ b/website/manual.md
@@ -176,7 +176,7 @@ Extra steps for Windows users:
./third_party/depot_tools/ninja -C target/debug
# Build a release binary.
-DENO_BUILD_MODE=release ./tools/build.py :deno
+./tools/build.py --release deno
# List executable targets.
./third_party/depot_tools/gn ls target/debug //:* --as=output --type=executable
@@ -622,9 +622,8 @@ To start profiling,
```sh
# Make sure we're only building release.
-export DENO_BUILD_MODE=release
# Build deno and V8's d8.
-./tools/build.py d8 deno
+./tools/build.py --release d8 deno
# Start the program we want to benchmark with --prof
./target/release/deno tests/http_bench.ts --allow-net --prof &
# Exercise it.