summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSam Saccone <samccone@gmail.com>2018-06-04 00:41:51 -0700
committerRyan Dahl <ry@tinyclouds.org>2018-06-04 09:41:51 +0200
commit8e211ea68566b35701d5b6ab90408638db09d8fd (patch)
tree552e1064db4df3f4bc13a12c6b650293874be903
parent1e13a62f869a0440089db226f6f1531d836695b0 (diff)
📝 Update install instructions around known error (#110)
Even though the readme told me there was going to be an error, I was still confused about this error, as it looked unrelated to fetching the sources. To clarify this update the readme to spell out the expected error. Fixes #109
-rw-r--r--README.md15
1 files changed, 11 insertions, 4 deletions
diff --git a/README.md b/README.md
index e2991b349..b65e141fa 100644
--- a/README.md
+++ b/README.md
@@ -22,7 +22,7 @@ A secure TypeScript runtime on V8
code. Defaults to read-only file system access and no network access.
Access between V8 (unprivileged) and Golang (privileged) is only done via
serialized messages defined in this
- [protobuf](https://github.com/ry/deno/blob/master/msg.proto), this makes it
+ [protobuf](https://github.com/ry/deno/blob/master/msg.proto), this makes it
easy to audit.
To enable write access explicitly use `--allow-write` and `--allow-net` for
network access.
@@ -95,9 +95,16 @@ go get -u github.com/golang/protobuf/protoc-gen-go
go get -u github.com/jteeuwen/go-bindata/...
```
-You need to get and build [v8worker2](https://github.com/ry/v8worker2). The package will not build with `go
-get` and will log out an error, which can be ignored. It takes about 30 minutes
-to build:
+You need to get and build [v8worker2](https://github.com/ry/v8worker2). __The package will not build with `go
+get` and will log out an error ⚠__
+```bash
+# pkg-config --cflags v8.pc
+Failed to open 'v8.pc': No such file or directory
+No package 'v8.pc' found
+pkg-config: exit status 1
+```
+
+__which can be ignored__. It takes about 30 minutes to build:
``` bash
go get -u github.com/ry/v8worker2