diff options
| author | Matt Mastracci <matthew@mastracci.com> | 2024-02-21 12:10:51 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-21 19:10:51 +0000 |
| commit | 8aa529f1b8934fc8aefdfd721e363b71a7c9c269 (patch) | |
| tree | 17ae0932721ab52d4002fb50d491a8da7d778886 | |
| parent | bd66080217ebfd4f4f48d95e30f79d0dc57fd520 (diff) | |
chore(cli): fix part of flaky test (#22515)
| -rw-r--r-- | tests/integration/node_compat_tests.rs | 4 | ||||
| -rw-r--r-- | tests/testdata/node/test_no_sanitizers/test.js | 9 | ||||
| -rw-r--r-- | tests/testdata/node/test_no_sanitizers/test.out | 6 |
3 files changed, 12 insertions, 7 deletions
diff --git a/tests/integration/node_compat_tests.rs b/tests/integration/node_compat_tests.rs index 26f691636..c4c4ba1fa 100644 --- a/tests/integration/node_compat_tests.rs +++ b/tests/integration/node_compat_tests.rs @@ -16,6 +16,8 @@ itest!(node_test_module_no_sanitizers { args: "test -A --no-check node/test_no_sanitizers/test.js", output: "node/test_no_sanitizers/test.out", envs: env_vars_for_npm_tests(), - exit_code: 123, + exit_code: 0, + // TODO(mmastrac): fix exit sanitizer part of test + // exit_code: 123, http_server: true, }); diff --git a/tests/testdata/node/test_no_sanitizers/test.js b/tests/testdata/node/test_no_sanitizers/test.js index d2ca8a6c7..edd558710 100644 --- a/tests/testdata/node/test_no_sanitizers/test.js +++ b/tests/testdata/node/test_no_sanitizers/test.js @@ -22,7 +22,8 @@ test("should not complain about resource and op sanitizers", async (t) => { ); }); -test("should allow exit", () => { - // no exit sanitizers - Deno.exit(123); -}); +// TODO(mmastrac): This works, but we don't reliably flush stdout/stderr here, making this test flake +// test("should allow exit", () => { +// // no exit sanitizers +// Deno.exit(123); +// }); diff --git a/tests/testdata/node/test_no_sanitizers/test.out b/tests/testdata/node/test_no_sanitizers/test.out index f52bed3ab..5bd41aadf 100644 --- a/tests/testdata/node/test_no_sanitizers/test.out +++ b/tests/testdata/node/test_no_sanitizers/test.out @@ -1,5 +1,7 @@ -running 2 tests from ./node/test_no_sanitizers/test.js +running 1 test from ./node/test_no_sanitizers/test.js should not complain about resource and op sanitizers ... nested test ... ok ([WILDCARD]) should not complain about resource and op sanitizers ... ok ([WILDCARD]) -should allow exit ...
\ No newline at end of file + +ok | 1 passed (1 step) | 0 failed ([WILDCARD]) + |