diff options
author | Bert Belder <bertbelder@gmail.com> | 2019-06-11 23:17:41 +0200 |
---|---|---|
committer | Bert Belder <bertbelder@gmail.com> | 2019-06-11 23:17:41 +0200 |
commit | 878d092df9cc89ad92e571e2422ffb1ed488dd0e (patch) | |
tree | 6068032b6d5504aeb5534b6153b3b7c22c615c95 | |
parent | 7fc3d5ed8bef7373b96e4436dee8c68bec383184 (diff) |
Revert "Work around Windows-only V8 concurrent initialization crash"
This fix is no longer necessary as the underlying V8 bug has been
fixed upstream.
This reverts commit 48bcfce09e11901244447617be2eb7789427eab0.
-rw-r--r-- | core/libdeno/api.cc | 19 |
1 files changed, 1 insertions, 18 deletions
diff --git a/core/libdeno/api.cc b/core/libdeno/api.cc index bcdf7131b..8a3a56156 100644 --- a/core/libdeno/api.cc +++ b/core/libdeno/api.cc @@ -5,10 +5,6 @@ #include <iostream> #include <string> -// Cpplint bans the use of <mutex> because it duplicates functionality in -// chromium //base. However Deno doensn't use that, so suppress this lint. -#include <mutex> // NOLINT - #include "third_party/v8/include/libplatform/libplatform.h" #include "third_party/v8/include/v8.h" #include "third_party/v8/src/base/logging.h" @@ -57,20 +53,7 @@ Deno* deno_new(deno_config config) { params.snapshot_blob = &d->snapshot_; } - v8::Isolate* isolate; - { -#ifdef _WIN32 - // Work around an apparent V8 bug where initializing multiple isolates - // concurrently leads to a crash. At the time of writing the cause of this - // crash is not exactly understood, but it seems to be related to the V8 - // internal function win64_unwindinfo::RegisterNonABICompliantCodeRange(), - // which didn't exist in older versions of V8. - static std::mutex mutex; - std::lock_guard<std::mutex> lock(mutex); -#endif - isolate = v8::Isolate::New(params); - } - + v8::Isolate* isolate = v8::Isolate::New(params); d->AddIsolate(isolate); v8::Locker locker(isolate); |