diff options
| author | Kitson Kelly <me@kitsonkelly.com> | 2019-02-14 12:12:11 +1100 |
|---|---|---|
| committer | Ryan Dahl <ry@tinyclouds.org> | 2019-02-13 20:12:11 -0500 |
| commit | 8686f49ee4e9fff1e0eeb29af2e81a678a3f2260 (patch) | |
| tree | 94b4777e349082878f9d15e733bb272bff730387 | |
| parent | 8d1567fafbdac8cd76e736d203eacc578d932a94 (diff) | |
Update contribution guidelines (#1771)
To make it clearer how people should indicate that are contributing to Deno.
| -rw-r--r-- | website/manual.md | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/website/manual.md b/website/manual.md index da0948e06..271974d26 100644 --- a/website/manual.md +++ b/website/manual.md @@ -609,14 +609,18 @@ Please don't make [the benchmarks](https://deno.land/benchmarks.html) worse. Ask for help in the [community chat room](https://gitter.im/denolife/Lobby). +If you are going to work on an issue, mention so in the issue comments _before_ +you start working on the issue. + ### Submitting a pull request Before submitting, please make sure the following is done: -1. There are tests that cover the changes. -2. Ensure `./tools/test.py` passes. -3. Format your code with `tools/format.py` -4. Make sure `./tools/lint.py` passes. +1. That there is a related issue and it is referenced in the PR text. +2. There are tests that cover the changes. +3. Ensure `./tools/test.py` passes. +4. Format your code with `tools/format.py` +5. Make sure `./tools/lint.py` passes. ### Changes to `third_party` |