summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNimalan <nimalan.m@protonmail.com>2019-09-04 20:12:40 +0530
committerRyan Dahl <ry@tinyclouds.org>2019-09-04 10:42:40 -0400
commit7213d9cc7f8b802d3345c9afa6968ab2ad05fd56 (patch)
treebf48f858acd0dacfaeb4c77e7587d320825d3a81
parenteea856e341a5381c6a5744db1ee6fe590cf8ffd3 (diff)
ws: use crypto getRandomValues (denoland/deno_std#584)
Original: https://github.com/denoland/deno_std/commit/bc7dd3904bede90b9e7ae96674446ab6e9d4ccfc
-rw-r--r--ws/mod.ts6
1 files changed, 1 insertions, 5 deletions
diff --git a/ws/mod.ts b/ws/mod.ts
index b649ef178..ce2b90e3a 100644
--- a/ws/mod.ts
+++ b/ws/mod.ts
@@ -189,11 +189,7 @@ export async function readFrame(buf: BufReader): Promise<WebSocketFrame> {
// Create client-to-server mask, random 32bit number
function createMask(): Uint8Array {
- // TODO: use secure and immutable random function. Crypto.getRandomValues()
- const arr = Array.from({ length: 4 }).map(
- (): number => Math.round(Math.random() * 0xff)
- );
- return new Uint8Array(arr);
+ return crypto.getRandomValues(new Uint8Array(4));
}
class WebSocketImpl implements WebSocket {