summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYusuke Sakurai <kerokerokerop@gmail.com>2020-02-14 06:05:30 +0900
committerGitHub <noreply@github.com>2020-02-13 16:05:30 -0500
commit621aeef8364fcbd2da93b208971c51a4fbf08903 (patch)
tree1fd7d466701e94638c422d4fa56e886f45d381de
parent9325744a9426241a2826a6fb5516269227e26efa (diff)
fix: appended CRLF to end of trailer headers (#3989)
-rw-r--r--std/http/server.ts1
-rw-r--r--std/http/server_test.ts3
2 files changed, 3 insertions, 1 deletions
diff --git a/std/http/server.ts b/std/http/server.ts
index b8a41379f..c6a895a1f 100644
--- a/std/http/server.ts
+++ b/std/http/server.ts
@@ -84,6 +84,7 @@ export async function writeTrailers(
);
await writer.write(encoder.encode(`${key}: ${value}\r\n`));
}
+ await writer.write(encoder.encode("\r\n"));
await writer.flush();
}
diff --git a/std/http/server_test.ts b/std/http/server_test.ts
index a18cd273c..123bc7155 100644
--- a/std/http/server_test.ts
+++ b/std/http/server_test.ts
@@ -456,6 +456,7 @@ test("writeResponse with trailer", async () => {
"",
"deno: land",
"node: js",
+ "",
""
].join("\r\n");
assertEquals(ret, exp);
@@ -775,7 +776,7 @@ test("writeTrailer", async () => {
new Headers({ "transfer-encoding": "chunked", trailer: "deno,node" }),
new Headers({ deno: "land", node: "js" })
);
- assertEquals(w.toString(), "deno: land\r\nnode: js\r\n");
+ assertEquals(w.toString(), "deno: land\r\nnode: js\r\n\r\n");
});
test("writeTrailer should throw", async () => {