diff options
author | Divy Srivastava <dj.srivastava23@gmail.com> | 2024-10-02 12:52:05 +0530 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-10-02 12:52:05 +0530 |
commit | 620e6b43a66c2af44ae4aea62417af408309f61c (patch) | |
tree | 58fb27d241c85250a9fdc2a34111fb8e328c7d43 | |
parent | 3881b7173445ab7f68ec94d5dedbb1cb1c1978ec (diff) |
fix(ext/node): remove unimplemented promiseHook stubs (#25979)
`temporalio` sdk [will try to
use](https://github.com/temporalio/sdk-typescript/blob/faa64225a7f57154931a38c1fe612fc6520943b2/packages/worker/src/workflow/vm-shared.ts#L199-L202)
promiseHook if it is found. This patch removes the unimplemented stubs.
```ts
if (promiseHooks) {
// Node >=16.14 only
this.stopPromiseHook = promiseHooks.createHook({
init: (promise: Promise<unknown>, parent: Promise<unknown>) => {
```
Fixes https://github.com/denoland/deno/issues/25977
-rw-r--r-- | ext/node/polyfills/v8.ts | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/ext/node/polyfills/v8.ts b/ext/node/polyfills/v8.ts index 5849f3ccc..9df199865 100644 --- a/ext/node/polyfills/v8.ts +++ b/ext/node/polyfills/v8.ts @@ -313,20 +313,6 @@ export class DefaultDeserializer extends Deserializer { ); } } -export const promiseHooks = { - onInit() { - notImplemented("v8.promiseHooks.onInit"); - }, - onSettled() { - notImplemented("v8.promiseHooks.onSetttled"); - }, - onBefore() { - notImplemented("v8.promiseHooks.onBefore"); - }, - createHook() { - notImplemented("v8.promiseHooks.createHook"); - }, -}; export default { cachedDataVersionTag, getHeapCodeStatistics, @@ -343,5 +329,4 @@ export default { Deserializer, DefaultSerializer, DefaultDeserializer, - promiseHooks, }; |