summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRyan Dahl <ry@tinyclouds.org>2020-05-10 12:39:27 -0400
committerGitHub <noreply@github.com>2020-05-10 12:39:27 -0400
commit60dfd911de693263157e28e58e4307d6eb4a3476 (patch)
tree142cdcb9b8bd8b87af4d2fb861489356a2941cb0
parente9318aa2c0b64282a53d59bfe3c5b6bee224bf39 (diff)
ci: don't fail-fast on tag build (#5189)
-rw-r--r--.github/workflows/ci.yml5
1 files changed, 4 insertions, 1 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 43969e284..902dad72b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -29,8 +29,11 @@ jobs:
# Always run master branch builds to completion. This allows the cache to
# stay mostly up-to-date in situations where a single job fails due to
# e.g. a flaky test.
+ # Don't fast-fail on tag build because publishing binaries shouldn't be
+ # prevented if 'cargo publish' fails (which can be a false negative).
fail-fast:
- ${{ github.event_name != 'push' || github.ref != 'refs/heads/master' }}
+ ${{ github.event_name == 'pull_request' || (github.ref !=
+ 'refs/heads/master' && !startsWith(github.ref, 'refs/tags/')) }}
env:
CARGO_INCREMENTAL: 0