summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreu Botella <andreu@andreubotella.com>2022-03-22 22:57:15 +0100
committerGitHub <noreply@github.com>2022-03-22 22:57:15 +0100
commit49be140d2be79b7c94b4375c6a8629b1c0ad99e3 (patch)
tree55df7e8788c8a12dce139c6526d381a8f2b1ecb9
parent6268a1a6fde0980ea5eb86c689a89d2c41aab6d4 (diff)
chore(core): Remove a note that is no longer relevant. (#14069)
This note about how `v8::SnapshotCreator::create_blob` must not be called from a `HandleScope` stopped being relevant in #6801, and was now attached to code that had nothing to do with `HandleScope`s.
-rw-r--r--core/runtime.rs2
1 files changed, 0 insertions, 2 deletions
diff --git a/core/runtime.rs b/core/runtime.rs
index c2c2f4b92..fd884a709 100644
--- a/core/runtime.rs
+++ b/core/runtime.rs
@@ -662,8 +662,6 @@ impl JsRuntime {
let state = Self::state(self.v8_isolate());
- // Note: create_blob() method must not be called from within a HandleScope.
- // TODO(piscisaureus): The rusty_v8 type system should enforce this.
state.borrow_mut().global_context.take();
self.inspector.take();