summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorsnek <snek@deno.com>2024-09-13 17:28:35 -0700
committerGitHub <noreply@github.com>2024-09-13 17:28:35 -0700
commit2c0bf6fd65b3276c4818c73028b19819608c8e70 (patch)
tree8eab21bef4397eb4a8a0cbdba54373539154934e
parentd162733db2944b4c35d8c3e80f37f7de843dafa1 (diff)
fix(ext/node): attach console stream properties (#25617)
`kBindStreamsLazy` should be called with `process` during init, but it never was.
-rw-r--r--ext/node/polyfills/01_require.js2
-rw-r--r--ext/node/polyfills/02_init.js5
-rw-r--r--ext/node/polyfills/internal/console/constructor.mjs5
3 files changed, 12 insertions, 0 deletions
diff --git a/ext/node/polyfills/01_require.js b/ext/node/polyfills/01_require.js
index d9ecce690..156fa1bd0 100644
--- a/ext/node/polyfills/01_require.js
+++ b/ext/node/polyfills/01_require.js
@@ -128,6 +128,7 @@ import internalTestBinding from "ext:deno_node/internal/test/binding.ts";
import internalTimers from "ext:deno_node/internal/timers.mjs";
import internalUtil from "ext:deno_node/internal/util.mjs";
import internalUtilInspect from "ext:deno_node/internal/util/inspect.mjs";
+import internalConsole from "ext:deno_node/internal/console/constructor.mjs";
import net from "node:net";
import os from "node:os";
import pathPosix from "node:path/posix";
@@ -198,6 +199,7 @@ function setupBuiltinModules() {
http2,
https,
inspector,
+ "internal/console/constructor": internalConsole,
"internal/child_process": internalCp,
"internal/crypto/certificate": internalCryptoCertificate,
"internal/crypto/cipher": internalCryptoCipher,
diff --git a/ext/node/polyfills/02_init.js b/ext/node/polyfills/02_init.js
index 8a4aa8e97..b25f7ad57 100644
--- a/ext/node/polyfills/02_init.js
+++ b/ext/node/polyfills/02_init.js
@@ -82,3 +82,8 @@ nodeGlobals.setImmediate = nativeModuleExports["timers"].setImmediate;
nodeGlobals.setInterval = nativeModuleExports["timers"].setInterval;
nodeGlobals.setTimeout = nativeModuleExports["timers"].setTimeout;
nodeGlobals.performance = nativeModuleExports["perf_hooks"].performance;
+
+nativeModuleExports["internal/console/constructor"].bindStreamsLazy(
+ nativeModuleExports["console"],
+ nativeModuleExports["process"],
+);
diff --git a/ext/node/polyfills/internal/console/constructor.mjs b/ext/node/polyfills/internal/console/constructor.mjs
index 8f4689962..ebf5cbec4 100644
--- a/ext/node/polyfills/internal/console/constructor.mjs
+++ b/ext/node/polyfills/internal/console/constructor.mjs
@@ -667,10 +667,15 @@ Console.prototype.dirxml = Console.prototype.log;
Console.prototype.error = Console.prototype.warn;
Console.prototype.groupCollapsed = Console.prototype.group;
+export function bindStreamsLazy(console, object) {
+ Console.prototype[kBindStreamsLazy].call(console, object);
+}
+
export { Console, formatTime, kBindProperties, kBindStreamsLazy };
export default {
Console,
kBindStreamsLazy,
kBindProperties,
formatTime,
+ bindStreamsLazy,
};