summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Sherret <dsherret@users.noreply.github.com>2022-12-15 16:23:50 -0500
committerGitHub <noreply@github.com>2022-12-15 22:23:50 +0100
commit28cc18b5168d926577795eaf3974095da2def3e8 (patch)
tree5f953634536ea42bb1c63b527f9479893f04351e
parentb9527f502029fdf24ab9a98c6316e5d0f286a47d (diff)
fix(regression): ensure progress information is shown when downloading remote modules (#17069)
-rw-r--r--cli/file_fetcher.rs10
1 files changed, 6 insertions, 4 deletions
diff --git a/cli/file_fetcher.rs b/cli/file_fetcher.rs
index 539f9ccd3..f714a18ca 100644
--- a/cli/file_fetcher.rs
+++ b/cli/file_fetcher.rs
@@ -440,9 +440,9 @@ impl FileFetcher {
.boxed();
}
- let mut _maybe_guard = None;
+ let mut maybe_progress_guard = None;
if let Some(pb) = self.progress_bar.as_ref() {
- _maybe_guard = Some(pb.update(specifier.as_str()));
+ maybe_progress_guard = Some(pb.update(specifier.as_str()));
} else {
log::log!(
self.download_log_level,
@@ -463,7 +463,7 @@ impl FileFetcher {
let file_fetcher = self.clone();
// A single pass of fetch either yields code or yields a redirect.
async move {
- match fetch_once(
+ let result = match fetch_once(
&client,
FetchOnceArgs {
url: specifier.clone(),
@@ -497,7 +497,9 @@ impl FileFetcher {
file_fetcher.build_remote_file(&specifier, bytes, &headers)?;
Ok(file)
}
- }
+ };
+ drop(maybe_progress_guard);
+ result
}
.boxed()
}