summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAsher Gomez <ashersaupingomez@gmail.com>2024-09-03 19:07:19 +1000
committerGitHub <noreply@github.com>2024-09-03 09:07:19 +0000
commit1a82b0f8086133053c558084c567a0403c2708e9 (patch)
tree51c7df89951dce957cbc8c48a160f8527ead2143
parent71e4ac774bc18902a0d23f29d9b18b43b19bbbf2 (diff)
BREAKING(console): remove `Deno.customInspect` (#25348)
Note: this is implemented on Deploy. However, according to @magurotuna, a thin compatibility layer might be in the works that'd prevent breakages for PRs such as this one. Towards #22079
-rw-r--r--cli/tsc/dts/lib.deno.ns.d.ts13
-rw-r--r--runtime/js/99_main.js13
-rw-r--r--tests/specs/future/runtime_api/main.js1
-rw-r--r--tests/specs/future/runtime_api/main.out1
4 files changed, 0 insertions, 28 deletions
diff --git a/cli/tsc/dts/lib.deno.ns.d.ts b/cli/tsc/dts/lib.deno.ns.d.ts
index 8d9384580..40e065389 100644
--- a/cli/tsc/dts/lib.deno.ns.d.ts
+++ b/cli/tsc/dts/lib.deno.ns.d.ts
@@ -5216,19 +5216,6 @@ declare namespace Deno {
*/
export const args: string[];
- /**
- * A symbol which can be used as a key for a custom method which will be
- * called when `Deno.inspect()` is called, or when the object is logged to
- * the console.
- *
- * @deprecated This will be removed in Deno 2.0. See the
- * {@link https://docs.deno.com/runtime/manual/advanced/migrate_deprecations | Deno 1.x to 2.x Migration Guide}
- * for migration instructions.
- *
- * @category I/O
- */
- export const customInspect: unique symbol;
-
/** The URL of the entrypoint module entered from the command-line. It
* requires read permission to the CWD.
*
diff --git a/runtime/js/99_main.js b/runtime/js/99_main.js
index 764a7a23e..1854a73fa 100644
--- a/runtime/js/99_main.js
+++ b/runtime/js/99_main.js
@@ -56,7 +56,6 @@ import * as version from "ext:runtime/01_version.ts";
import * as os from "ext:runtime/30_os.js";
import * as timers from "ext:deno_web/02_timers.js";
import {
- customInspect,
getDefaultInspectOptions,
getStderrNoColor,
inspectArgs,
@@ -534,18 +533,6 @@ ObjectDefineProperties(finalDenoNs, {
noColor: core.propGetterOnly(() => op_bootstrap_no_color()),
args: core.propGetterOnly(opArgs),
mainModule: core.propGetterOnly(() => op_main_module()),
- // TODO(kt3k): Remove this export at v2
- // See https://github.com/denoland/deno/issues/9294
- customInspect: {
- get() {
- warnOnDeprecatedApi(
- "Deno.customInspect",
- new Error().stack,
- 'Use `Symbol.for("Deno.customInspect")` instead.',
- );
- return internals.future ? undefined : customInspect;
- },
- },
exitCode: {
get() {
return os.getExitCode();
diff --git a/tests/specs/future/runtime_api/main.js b/tests/specs/future/runtime_api/main.js
index a541c097f..a12b2f1fc 100644
--- a/tests/specs/future/runtime_api/main.js
+++ b/tests/specs/future/runtime_api/main.js
@@ -118,6 +118,5 @@ try {
console.log("Deno.ListenTlsOptions.(keyFile|certFile) do nothing");
}
}
-console.log("Deno.customInspect is", Deno.customInspect);
self.close();
diff --git a/tests/specs/future/runtime_api/main.out b/tests/specs/future/runtime_api/main.out
index 637c60dfc..398922749 100644
--- a/tests/specs/future/runtime_api/main.out
+++ b/tests/specs/future/runtime_api/main.out
@@ -29,4 +29,3 @@ Deno.FsFile constructor is illegal
Deno.ConnectTlsOptions.(certFile|keyFile) do nothing
Deno.ConnectTlsOptions.(certChain|privateKey) do nothing
Deno.ListenTlsOptions.(keyFile|certFile) do nothing
-Deno.customInspect is undefined