summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNathan Whitaker <17734409+nathanwhit@users.noreply.github.com>2024-10-16 19:58:11 -0700
committerGitHub <noreply@github.com>2024-10-16 19:58:11 -0700
commit167f674c7cbb9632000c1feb0b747ba098b01c12 (patch)
tree610529e9e2a08ab6412d821852f3015549b28f38
parent458d6278d2835896018086da773fd72b7af8ed66 (diff)
fix: don't warn on ignored signals on windows (#26332)
Closes #26183. The warnings are super noisy and not actionable for the user
-rw-r--r--ext/node/polyfills/process.ts4
-rw-r--r--tests/unit_node/process_test.ts28
2 files changed, 1 insertions, 31 deletions
diff --git a/ext/node/polyfills/process.ts b/ext/node/polyfills/process.ts
index 3dc6ce61a..2605fa6d1 100644
--- a/ext/node/polyfills/process.ts
+++ b/ext/node/polyfills/process.ts
@@ -520,9 +520,7 @@ Process.prototype.on = function (
} else if (
event !== "SIGBREAK" && event !== "SIGINT" && Deno.build.os === "windows"
) {
- // Ignores all signals except SIGBREAK and SIGINT on windows.
- // deno-lint-ignore no-console
- console.warn(`Ignoring signal "${event}" on Windows`);
+ // TODO(#26331): Ignores all signals except SIGBREAK and SIGINT on windows.
} else {
EventEmitter.prototype.on.call(this, event, listener);
Deno.addSignalListener(event as Deno.Signal, listener);
diff --git a/tests/unit_node/process_test.ts b/tests/unit_node/process_test.ts
index 9506fb609..f9138c8f0 100644
--- a/tests/unit_node/process_test.ts
+++ b/tests/unit_node/process_test.ts
@@ -25,7 +25,6 @@ import {
assertThrows,
fail,
} from "@std/assert";
-import { assertSpyCall, assertSpyCalls, spy } from "@std/testing/mock";
import { stripAnsiCode } from "@std/fmt/colors";
import * as path from "@std/path";
import { delay } from "@std/async/delay";
@@ -239,33 +238,6 @@ Deno.test({
},
});
-Deno.test({
- name: "process.on - ignored signals on windows",
- ignore: Deno.build.os !== "windows",
- fn() {
- const ignoredSignals = ["SIGHUP", "SIGUSR1", "SIGUSR2"];
-
- for (const signal of ignoredSignals) {
- using consoleSpy = spy(console, "warn");
- const handler = () => {};
- process.on(signal, handler);
- process.off(signal, handler);
- assertSpyCall(consoleSpy, 0, {
- args: [`Ignoring signal "${signal}" on Windows`],
- });
- }
-
- {
- using consoleSpy = spy(console, "warn");
- const handler = () => {};
- process.on("SIGTERM", handler);
- process.off("SIGTERM", handler);
- // No warning is made for SIGTERM
- assertSpyCalls(consoleSpy, 0);
- }
- },
-});
-
Deno.test(
{ permissions: { run: true, read: true } },
async function processKill() {