summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Sherret <dsherret@users.noreply.github.com>2022-12-01 12:26:33 -0500
committerGitHub <noreply@github.com>2022-12-01 12:26:33 -0500
commit1615852025f87433a217877489f47a12c45dc497 (patch)
tree628920a1d20501f80361e7b3a7f70a5fb6a879f5
parentfafb3eebaf27cc2ef3ffaa10be8a0c5d78a112d0 (diff)
chore(npm): fix types tests (#16882)
-rw-r--r--cli/tests/npm_tests.rs12
-rw-r--r--cli/tests/testdata/npm/types_entry_value_not_exists/main.out5
-rw-r--r--cli/tests/testdata/npm/types_entry_value_not_exists/main.ts3
-rw-r--r--cli/tests/testdata/npm/types_exports_import_types/main.out5
-rw-r--r--cli/tests/testdata/npm/types_exports_import_types/main.ts3
-rw-r--r--cli/tests/testdata/npm/types_no_types_entry/main.out5
-rw-r--r--cli/tests/testdata/npm/types_no_types_entry/main.ts3
7 files changed, 24 insertions, 12 deletions
diff --git a/cli/tests/npm_tests.rs b/cli/tests/npm_tests.rs
index 39dd1d549..61b2dc886 100644
--- a/cli/tests/npm_tests.rs
+++ b/cli/tests/npm_tests.rs
@@ -320,27 +320,27 @@ mod npm {
});
itest!(types_entry_value_not_exists {
- args: "run --check=all npm/types_entry_value_not_exists/main.ts",
+ args: "check --remote npm/types_entry_value_not_exists/main.ts",
output: "npm/types_entry_value_not_exists/main.out",
envs: env_vars_for_npm_tests(),
http_server: true,
- exit_code: 0,
+ exit_code: 1,
});
itest!(types_exports_import_types {
- args: "run --check=all npm/types_exports_import_types/main.ts",
+ args: "check --remote npm/types_exports_import_types/main.ts",
output: "npm/types_exports_import_types/main.out",
envs: env_vars_for_npm_tests(),
http_server: true,
- exit_code: 0,
+ exit_code: 1,
});
itest!(types_no_types_entry {
- args: "run --check=all npm/types_no_types_entry/main.ts",
+ args: "check --remote npm/types_no_types_entry/main.ts",
output: "npm/types_no_types_entry/main.out",
envs: env_vars_for_npm_tests(),
http_server: true,
- exit_code: 0,
+ exit_code: 1,
});
itest!(typescript_file_in_package {
diff --git a/cli/tests/testdata/npm/types_entry_value_not_exists/main.out b/cli/tests/testdata/npm/types_entry_value_not_exists/main.out
index 036857827..0bb31a195 100644
--- a/cli/tests/testdata/npm/types_entry_value_not_exists/main.out
+++ b/cli/tests/testdata/npm/types_entry_value_not_exists/main.out
@@ -1,4 +1,7 @@
Download http://localhost:4545/npm/registry/@denotest/types-entry-value-not-exists
Download http://localhost:4545/npm/registry/@denotest/types-entry-value-not-exists/1.0.0.tgz
Check file://[WILDCARD]/types_entry_value_not_exists/main.ts
-5
+error: TS2322 [ERROR]: Type 'number' is not assignable to type 'string'.
+const result: string = getValue();
+ ~~~~~~
+ at file:///[WILDCARD]/main.ts:4:7
diff --git a/cli/tests/testdata/npm/types_entry_value_not_exists/main.ts b/cli/tests/testdata/npm/types_entry_value_not_exists/main.ts
index d8fca712c..04374ef87 100644
--- a/cli/tests/testdata/npm/types_entry_value_not_exists/main.ts
+++ b/cli/tests/testdata/npm/types_entry_value_not_exists/main.ts
@@ -1,4 +1,5 @@
import { getValue } from "npm:@denotest/types-entry-value-not-exists";
-const result: 5 = getValue();
+// should error here
+const result: string = getValue();
console.log(result);
diff --git a/cli/tests/testdata/npm/types_exports_import_types/main.out b/cli/tests/testdata/npm/types_exports_import_types/main.out
index 6f6cb8366..a3db009ca 100644
--- a/cli/tests/testdata/npm/types_exports_import_types/main.out
+++ b/cli/tests/testdata/npm/types_exports_import_types/main.out
@@ -1,4 +1,7 @@
Download http://localhost:4545/npm/registry/@denotest/types-exports-import-types
Download http://localhost:4545/npm/registry/@denotest/types-exports-import-types/1.0.0.tgz
Check file://[WILDCARD]/types_exports_import_types/main.ts
-5
+error: TS2322 [ERROR]: Type 'number' is not assignable to type 'string'.
+const result: string = getValue();
+ ~~~~~~
+ at file:///[WILDCARD]/main.ts:4:7
diff --git a/cli/tests/testdata/npm/types_exports_import_types/main.ts b/cli/tests/testdata/npm/types_exports_import_types/main.ts
index 00b69c438..3ae3e92a3 100644
--- a/cli/tests/testdata/npm/types_exports_import_types/main.ts
+++ b/cli/tests/testdata/npm/types_exports_import_types/main.ts
@@ -1,4 +1,5 @@
import { getValue } from "npm:@denotest/types-exports-import-types";
-const result: 5 = getValue();
+// should error here
+const result: string = getValue();
console.log(result);
diff --git a/cli/tests/testdata/npm/types_no_types_entry/main.out b/cli/tests/testdata/npm/types_no_types_entry/main.out
index 6c5d45222..2aa78dd25 100644
--- a/cli/tests/testdata/npm/types_no_types_entry/main.out
+++ b/cli/tests/testdata/npm/types_no_types_entry/main.out
@@ -1,4 +1,7 @@
Download http://localhost:4545/npm/registry/@denotest/types-no-types-entry
Download http://localhost:4545/npm/registry/@denotest/types-no-types-entry/1.0.0.tgz
Check file://[WILDCARD]/types_no_types_entry/main.ts
-5
+error: TS2322 [ERROR]: Type 'number' is not assignable to type 'string'.
+const result: string = getValue();
+ ~~~~~~
+ at file:///[WILDCARD]/main.ts:4:7
diff --git a/cli/tests/testdata/npm/types_no_types_entry/main.ts b/cli/tests/testdata/npm/types_no_types_entry/main.ts
index 15e060402..eef53b681 100644
--- a/cli/tests/testdata/npm/types_no_types_entry/main.ts
+++ b/cli/tests/testdata/npm/types_no_types_entry/main.ts
@@ -1,4 +1,5 @@
import { getValue } from "npm:@denotest/types-no-types-entry";
-const result: 5 = getValue();
+// should error here
+const result: string = getValue();
console.log(result);