summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKenta Moriuchi <moriken@kimamass.com>2023-11-11 17:23:01 +0900
committerGitHub <noreply@github.com>2023-11-11 08:23:01 +0000
commit0c1ab2c7f7a6ebf7856df71dbd790d0d731f1b86 (patch)
tree75117146bf31e8bb9a119746b344130e679e3a86
parentb2e3389a6aebe5378f49fa86391255f9fc8b0707 (diff)
fix(ext/node): Re-enable alloc max size test (#21059)
Ref #21036
-rw-r--r--cli/tests/node_compat/test/parallel/test-buffer-alloc.js14
1 files changed, 6 insertions, 8 deletions
diff --git a/cli/tests/node_compat/test/parallel/test-buffer-alloc.js b/cli/tests/node_compat/test/parallel/test-buffer-alloc.js
index f6d74f6a1..46517ec1e 100644
--- a/cli/tests/node_compat/test/parallel/test-buffer-alloc.js
+++ b/cli/tests/node_compat/test/parallel/test-buffer-alloc.js
@@ -13,14 +13,12 @@ const assert = require('assert');
const SlowBuffer = require('buffer').SlowBuffer;
-// TODO(bartlomieju): this test started failing after update to V8 12.0,
-// maybe the size limit was increased?
-// Verify the maximum Uint8Array size. There is no concrete limit by spec. The
-// internal limits should be updated if this fails.
-// assert.throws(
-// () => new Uint8Array(2 ** 32 + 1),
-// { message: 'Invalid typed array length: 4294967297' }
-// );
+// Verify the maximum Uint8Array size.
+// (see https://github.com/tc39/ecma262/pull/3052).
+assert.throws(
+ () => new Uint8Array(2 ** 53),
+ { message: 'Invalid typed array length: 9007199254740992' }
+);
const b = Buffer.allocUnsafe(1024);
assert.strictEqual(b.length, 1024);