diff options
| author | Maxime Guerreiro <maxime.guerreiro@gmail.com> | 2021-06-22 17:47:09 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-06-22 17:47:09 +0200 |
| commit | 02f7a52235e9db54c5d8cb2015ece0fb1be03362 (patch) | |
| tree | dd0ee967c4e7bf354661584b5bd7a7c434a604d0 | |
| parent | 20b0a5125a80c027f21472eec98f29e5e35629fb (diff) | |
cleanup(core): top-level-await is now always enabled (#11082)
Starting with V8 9.1, top-level-await is always enabled by default.
See https://v8.dev/blog/v8-release-91 for the release notes.
- Remove the now redundant v8 flag.
- Clarify doc comment and add link to the feature explainer.
| -rw-r--r-- | core/runtime.rs | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/core/runtime.rs b/core/runtime.rs index 12578fb69..41948700f 100644 --- a/core/runtime.rs +++ b/core/runtime.rs @@ -162,7 +162,6 @@ fn v8_init(v8_platform: Option<v8::UniquePtr<v8::Platform>>) { // See https://github.com/denoland/deno/issues/2544 " --experimental-wasm-threads", " --no-wasm-async-compilation", - " --harmony-top-level-await", " --harmony-import-assertions", " --no-validate-asm", ); @@ -1139,9 +1138,9 @@ impl JsRuntime { } } - /// "deno_core" runs V8 with "--harmony-top-level-await" - /// flag on - it means that each module evaluation returns a promise - /// from V8. + /// "deno_core" runs V8 with Top Level Await enabled. It means that each + /// module evaluation returns a promise from V8. + /// Feature docs: https://v8.dev/features/top-level-await /// /// This promise resolves after all dependent modules have also /// resolved. Each dependent module may perform calls to "import()" and APIs |