diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2023-03-08 12:22:08 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-08 12:22:08 -0500 |
| commit | 23e1ba7e2dba1b9453e064f6c92c10b64071b708 (patch) | |
| tree | cf56494b547c96cd20a03d4393eb90656fac3a3a /.gitignore | |
| parent | 0cce9c2bcc9667935a571d30847e66ef5d01a196 (diff) | |
fix(npm): improve peer dependency resolution with circular dependencies (#18069)
This improves peer dependency resolution yet again. We did not handle
scenarios like the following:
```
// a -> b -> c -> d -> c -> b (peer)
```
...which would maybe work ok the first time its run in some cases, but
then lead to a lockfile that would error on load.
This now keeps track of circular dependencies and updates nodes
accordingly. That said, there is still a lurking bug in this code
somewhere that I've added a comment for (there is a mitigation on the
tail end that seems to work well). The current state is much better than
before and I can look into it later. I think it's something small that's
incorrect.
Diffstat (limited to '.gitignore')
| -rw-r--r-- | .gitignore | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/.gitignore b/.gitignore index 19e60deba..59166931a 100644 --- a/.gitignore +++ b/.gitignore @@ -5,6 +5,7 @@ /.cargo_home/ /.idea/ +/.vs/ /.vscode/ gclient_config.py_entries /gh-pages/ |