diff options
| author | Bartek Iwańczuk <biwanczuk@gmail.com> | 2023-05-26 06:40:17 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-26 10:10:17 +0530 |
| commit | 512d5337c480a2a2704881d3fe1c40b6e0445cf0 (patch) | |
| tree | 99b03358883223a69f48b2d0e5b9387f3abae517 /.github/workflows | |
| parent | 7ae55e75d812edc93251357465f8d49fc2fb5d26 (diff) | |
fix(napi): clear currently registering module slot (#19249)
This commit fixes problem with loading N-API modules that use
the "old" way of registration (using "napi_module_register" API).
The slot was not cleared after loading modules, causing subsequent
calls that use the new way of registration (using
"napi_register_module_v1" API) to try and load the previous module.
Ref https://github.com/denoland/deno/issues/16460
---------
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
Diffstat (limited to '.github/workflows')
| -rwxr-xr-x | .github/workflows/ci.generate.ts | 4 | ||||
| -rw-r--r-- | .github/workflows/ci.yml | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/.github/workflows/ci.generate.ts b/.github/workflows/ci.generate.ts index c1f1eef6b..44fd3c47c 100755 --- a/.github/workflows/ci.generate.ts +++ b/.github/workflows/ci.generate.ts @@ -17,7 +17,7 @@ const Runners = (() => { })(); // bump the number at the start when you want to purge the cache const prCacheKeyPrefix = - "29-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ matrix.job }}-"; + "31-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ matrix.job }}-"; const installPkgsCommand = "sudo apt-get install --no-install-recommends debootstrap clang-15 lld-15"; @@ -480,7 +480,7 @@ const ci = { "~/.cargo/git/db", ].join("\n"), key: - "29-cargo-home-${{ matrix.os }}-${{ hashFiles('Cargo.lock') }}", + "31-cargo-home-${{ matrix.os }}-${{ hashFiles('Cargo.lock') }}", }, }, { diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c78791ee5..97219b4d0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -293,7 +293,7 @@ jobs: ~/.cargo/registry/index ~/.cargo/registry/cache ~/.cargo/git/db - key: '29-cargo-home-${{ matrix.os }}-${{ hashFiles(''Cargo.lock'') }}' + key: '31-cargo-home-${{ matrix.os }}-${{ hashFiles(''Cargo.lock'') }}' if: '!(github.event_name == ''pull_request'' && matrix.skip_pr)' - name: Restore cache build output (PR) uses: actions/cache/restore@v3 @@ -305,7 +305,7 @@ jobs: !./target/*/*.zip !./target/*/*.tar.gz key: never_saved - restore-keys: '29-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ matrix.job }}-' + restore-keys: '31-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ matrix.job }}-' - name: Apply and update mtime cache if: '!(github.event_name == ''pull_request'' && matrix.skip_pr) && (!startsWith(github.ref, ''refs/tags/''))' uses: ./.github/mtime_cache @@ -589,7 +589,7 @@ jobs: !./target/*/gn_out !./target/*/*.zip !./target/*/*.tar.gz - key: '29-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ matrix.job }}-${{ github.sha }}' + key: '31-cargo-target-${{ matrix.os }}-${{ matrix.profile }}-${{ matrix.job }}-${{ github.sha }}' publish-canary: name: publish canary runs-on: ubuntu-22.04 |