From fbcbbd7ae3fa2d57e8ad026a1f9f01c6d07fd80b Mon Sep 17 00:00:00 2001 From: Andreu Botella Date: Mon, 11 Oct 2021 09:50:18 -0700 Subject: fix(runtime): Declare `Window.self` and `DedicatedWorkerGlobalScope.name` with `util.writable()` (#12378) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `Window`'s `self` property and `DedicatedWorkerGlobalScope`'s `name` property are defined as Web IDL read-only attributes with the `[Replaceable]` extended attribute, meaning that their setter will redefine the property as a data property with the set value, rather than changing some internal state. Deno currently defines them as read-only data properties instead. Given that Web IDL requires all attributes to be accessor properties rather than data properties, but Deno exposes almost all of those properties as either read-only or writable data properties, it makes sense to expose `[Replaceable]` properties as writable as well – as is already the case with `WindowOrWorkerGlobalScope`'s `performance` property. --- tools/wpt/expectation.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tools') diff --git a/tools/wpt/expectation.json b/tools/wpt/expectation.json index 511e1ddad..8e631f471 100644 --- a/tools/wpt/expectation.json +++ b/tools/wpt/expectation.json @@ -27840,7 +27840,7 @@ "headers-normalize.any.html": true, "headers-record.any.html": true, "headers-structure.any.html": true, - "headers-basic.any.worker.html": false, + "headers-basic.any.worker.html": true, "headers-casing.any.worker.html": true, "headers-combine.any.worker.html": true, "headers-errors.any.worker.html": true, -- cgit v1.2.3