From 47f7bed677a6b72e873712de8f3988ea891710e4 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Wed, 8 May 2024 22:45:06 -0400 Subject: chore: enable clippy::print_stdout and clippy::print_stderr (#23732) 1. Generally we should prefer to use the `log` crate. 2. I very often accidentally commit `eprintln`s. When we should use `println` or `eprintln`, it's not too bad to be a bit more verbose and ignore the lint rule. --- tools/lint.js | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'tools') diff --git a/tools/lint.js b/tools/lint.js index 2bb91f3d5..0fe96b049 100755 --- a/tools/lint.js +++ b/tools/lint.js @@ -162,6 +162,12 @@ async function clippy() { "warnings", "--deny", "clippy::unused_async", + // generally prefer the `log` crate, but ignore + // these print_* rules if necessary + "--deny", + "clippy::print_stderr", + "--deny", + "clippy::print_stdout", ], stdout: "inherit", stderr: "inherit", -- cgit v1.2.3