From 2338e7679c8840314642dbf3ea838908f5f35d3c Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Thu, 30 Jan 2020 10:49:33 -0500 Subject: Remove --current-thread flag (#3830) This flag was added to evaluate performance relative to tokio's threaded runtime. Although it's faster in the HTTP benchmark, it's clear the runtime is not the only perf problem. Removing this flag will simplify further refactors, in particular adopting the #[tokio::main] macro. This will be done in a follow up. Ultimately we expect to move to the current thread runtime with Isolates pinned to specific threads, but that will be a much larger refactor. The --current-thread just complicates that effort. --- tools/http_benchmark.py | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'tools') diff --git a/tools/http_benchmark.py b/tools/http_benchmark.py index 03f9f4365..d46d8a33d 100755 --- a/tools/http_benchmark.py +++ b/tools/http_benchmark.py @@ -42,17 +42,6 @@ def deno_tcp(deno_exe): return run(deno_cmd, port) -def deno_tcp_current_thread(deno_exe): - port = get_port() - deno_cmd = [ - deno_exe, "run", "--current-thread", "--allow-net", - "tools/deno_tcp.ts", - server_addr(port) - ] - print "http_benchmark testing DENO tcp (single-thread)." - return run(deno_cmd, port) - - def deno_http(deno_exe): port = get_port() deno_cmd = [ @@ -154,7 +143,6 @@ def http_benchmark(build_dir): return { # "deno_tcp" was once called "deno" "deno_tcp": deno_tcp(deno_exe), - "deno_tcp_current_thread": deno_tcp_current_thread(deno_exe), # "deno_http" was once called "deno_net_http" "deno_http": deno_http(deno_exe), "deno_proxy": deno_http_proxy(deno_exe, hyper_hello_exe), -- cgit v1.2.3