From 1fa75f75c90b744d63e451519311f27ba55c21d7 Mon Sep 17 00:00:00 2001 From: Colin Ihrig Date: Mon, 16 May 2022 10:46:39 -0400 Subject: fix(ext/web): throw if listener and signal are null (#14601) This commit fixes a failing WPT test by making EventTarget's addEventListener() method throw if both the listener and the signal option are null. Fixes: https://github.com/denoland/deno/issues/14593 --- tools/wpt/expectation.json | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) (limited to 'tools') diff --git a/tools/wpt/expectation.json b/tools/wpt/expectation.json index 2fa5f6e68..018b3ebd3 100644 --- a/tools/wpt/expectation.json +++ b/tools/wpt/expectation.json @@ -902,28 +902,16 @@ "event.any.worker.html": true }, "events": { - "AddEventListenerOptions-once.any.html": [ - "Once listener should be added / removed like normal listeners" - ], - "AddEventListenerOptions-once.any.worker.html": [ - "Once listener should be added / removed like normal listeners" - ], + "AddEventListenerOptions-once.any.html": true, + "AddEventListenerOptions-once.any.worker.html": true, "AddEventListenerOptions-passive.any.html": [ - "Supports passive option on addEventListener only", - "returnValue should be ignored if-and-only-if the passive option is true", - "Equivalence of option values" + "returnValue should be ignored if-and-only-if the passive option is true" ], "AddEventListenerOptions-passive.any.worker.html": [ - "Supports passive option on addEventListener only", - "returnValue should be ignored if-and-only-if the passive option is true", - "Equivalence of option values" - ], - "AddEventListenerOptions-signal.any.html": [ - "Passing null as the signal should throw (listener is also null)" - ], - "AddEventListenerOptions-signal.any.worker.html": [ - "Passing null as the signal should throw (listener is also null)" + "returnValue should be ignored if-and-only-if the passive option is true" ], + "AddEventListenerOptions-signal.any.html": true, + "AddEventListenerOptions-signal.any.worker.html": true, "Event-isTrusted.any.html": true, "Event-isTrusted.any.worker.html": true, "EventTarget-add-remove-listener.any.html": true, @@ -4787,4 +4775,4 @@ "idlharness.https.any.worker.html": true, "idlharness-shadowrealm.window.html": false } -} \ No newline at end of file +} -- cgit v1.2.3