From 520bdb6c31dd08b6f4e52de5116fd23d6d57fdda Mon Sep 17 00:00:00 2001 From: Daniel Buckmaster Date: Thu, 8 Aug 2019 21:25:39 +1000 Subject: Fix repl crash when deno dir doesn't exist (#2727) --- tools/repl_test.py | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) (limited to 'tools/repl_test.py') diff --git a/tools/repl_test.py b/tools/repl_test.py index 5ad7722ee..77e54dfdf 100644 --- a/tools/repl_test.py +++ b/tools/repl_test.py @@ -11,7 +11,12 @@ class TestRepl(DenoTestCase): def input(self, *lines, **kwargs): exit_ = kwargs.pop("exit", True) sleep_ = kwargs.pop("sleep", 0) - p = Popen([self.deno_exe], stdout=PIPE, stderr=PIPE, stdin=PIPE) + env_ = kwargs.pop("env", None) + p = Popen([self.deno_exe], + stdout=PIPE, + stderr=PIPE, + stdin=PIPE, + env=env_) try: # Note: The repl takes a >100ms until it's ready. time.sleep(sleep_) @@ -137,6 +142,14 @@ class TestRepl(DenoTestCase): self.assertEqual(err, '') self.assertEqual(code, 0) + def test_missing_deno_dir(self): + new_env = os.environ.copy() + new_env["DENO_DIR"] = os.path.abspath("doesnt_exist") + out, err, code = self.input("'noop'", exit=False, env=new_env) + self.assertEqual(out, "noop\n") + self.assertTrue(err.startswith("Unable to save REPL history:")) + self.assertEqual(code, 0) + if __name__ == "__main__": run_tests() -- cgit v1.2.3