From ce1d668929a91da2dc204f6bcc53afd5173c0a33 Mon Sep 17 00:00:00 2001 From: Yoshiya Hinosawa Date: Sun, 8 Sep 2024 12:22:18 +0900 Subject: fix(ext/node): delay accept() call 2 ticks in net.Server#listen (#25481) A workaround for the issue #25480 `Deno.Listener` can't be closed synchronously after `accept()` is called. This PR delays the `accept` call 2 ticks (The listener callback is called 1 tick later. So the 1 tick delay is not enough), and makes `net.Server` capable of being closed synchronously. This unblocks `npm:detect-port` and `npm:portfinder` closes #18301 closes #25175 --- tests/unit_node/net_test.ts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) (limited to 'tests') diff --git a/tests/unit_node/net_test.ts b/tests/unit_node/net_test.ts index 708d06386..8196874f3 100644 --- a/tests/unit_node/net_test.ts +++ b/tests/unit_node/net_test.ts @@ -228,3 +228,22 @@ Deno.test("[node/net] BlockList doesn't leak resources", () => { blockList.addAddress("1.1.1.1"); assert(blockList.check("1.1.1.1")); }); + +Deno.test("[node/net] net.Server can listen on the same port immediately after it's closed", async () => { + const serverClosed = Promise.withResolvers(); + const server = net.createServer(); + server.on("error", (e) => { + console.error(e); + }); + server.listen(0, () => { + // deno-lint-ignore no-explicit-any + const { port } = server.address() as any; + server.close(); + server.listen(port, () => { + server.close(() => { + serverClosed.resolve(); + }); + }); + }); + await serverClosed.promise; +}); -- cgit v1.2.3