From c64aa50c0e4219ef623a6ec3b939ac10a4568563 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <biwanczuk@gmail.com>
Date: Wed, 11 Sep 2024 16:19:45 +0100
Subject: feat(upgrade): better error message on failure (#25503)

Co-authored-by: crowlkats <crowlkats@toaxl.com>
---
 tests/specs/upgrade/invalid_version/__test__.jsonc | 19 +++++++++++++++++++
 tests/specs/upgrade/invalid_version/canary.out     | 17 +++++++++++++++++
 tests/specs/upgrade/invalid_version/shorthand.out  | 17 +++++++++++++++++
 tests/specs/upgrade/invalid_version/version.out    | 17 +++++++++++++++++
 4 files changed, 70 insertions(+)
 create mode 100644 tests/specs/upgrade/invalid_version/__test__.jsonc
 create mode 100644 tests/specs/upgrade/invalid_version/canary.out
 create mode 100644 tests/specs/upgrade/invalid_version/shorthand.out
 create mode 100644 tests/specs/upgrade/invalid_version/version.out

(limited to 'tests')

diff --git a/tests/specs/upgrade/invalid_version/__test__.jsonc b/tests/specs/upgrade/invalid_version/__test__.jsonc
new file mode 100644
index 000000000..1fa81c107
--- /dev/null
+++ b/tests/specs/upgrade/invalid_version/__test__.jsonc
@@ -0,0 +1,19 @@
+{
+  "tests": {
+    "canary": {
+      "args": "upgrade --canary asdfasdf",
+      "output": "canary.out",
+      "exitCode": 1
+    },
+    "version": {
+      "args": "upgrade --version asdfasdf",
+      "output": "version.out",
+      "exitCode": 1
+    },
+    "shorthand": {
+      "args": "upgrade asdfasdf",
+      "output": "shorthand.out",
+      "exitCode": 1
+    }
+  }
+}
diff --git a/tests/specs/upgrade/invalid_version/canary.out b/tests/specs/upgrade/invalid_version/canary.out
new file mode 100644
index 000000000..60a7b9f09
--- /dev/null
+++ b/tests/specs/upgrade/invalid_version/canary.out
@@ -0,0 +1,17 @@
+error: Invalid commit hash passed (asdfasdf)
+
+Pass a semver, or a full 40 character git commit hash, or a release channel name.
+
+Usage:
+Latest
+  deno upgrade
+
+Specific version
+  deno upgrade 1.45.0
+  deno upgrade 1.46.0-rc.1
+  deno upgrade 9bc2dd29ad6ba334fd57a20114e367d3c04763d4
+
+Channel
+  deno upgrade stable
+  deno upgrade rc
+  deno upgrade canary
diff --git a/tests/specs/upgrade/invalid_version/shorthand.out b/tests/specs/upgrade/invalid_version/shorthand.out
new file mode 100644
index 000000000..134284cab
--- /dev/null
+++ b/tests/specs/upgrade/invalid_version/shorthand.out
@@ -0,0 +1,17 @@
+error: Invalid version passed (asdfasdf)
+
+Pass a semver, or a full 40 character git commit hash, or a release channel name.
+
+Usage:
+Latest
+  deno upgrade
+
+Specific version
+  deno upgrade 1.45.0
+  deno upgrade 1.46.0-rc.1
+  deno upgrade 9bc2dd29ad6ba334fd57a20114e367d3c04763d4
+
+Channel
+  deno upgrade stable
+  deno upgrade rc
+  deno upgrade canary
diff --git a/tests/specs/upgrade/invalid_version/version.out b/tests/specs/upgrade/invalid_version/version.out
new file mode 100644
index 000000000..134284cab
--- /dev/null
+++ b/tests/specs/upgrade/invalid_version/version.out
@@ -0,0 +1,17 @@
+error: Invalid version passed (asdfasdf)
+
+Pass a semver, or a full 40 character git commit hash, or a release channel name.
+
+Usage:
+Latest
+  deno upgrade
+
+Specific version
+  deno upgrade 1.45.0
+  deno upgrade 1.46.0-rc.1
+  deno upgrade 9bc2dd29ad6ba334fd57a20114e367d3c04763d4
+
+Channel
+  deno upgrade stable
+  deno upgrade rc
+  deno upgrade canary
-- 
cgit v1.2.3