From c11e2c74e874af29b6ade13ee4ab51a72853d726 Mon Sep 17 00:00:00 2001 From: Yazan AbdAl-Rahman Date: Tue, 9 Jul 2024 14:44:12 +0300 Subject: fix(net): handle panic on Windows for Unix socket usage in Deno.serve() (#24423) This PR addresses the issue where Deno.serve() panics on Windows when trying to use a Unix socket. Fixes #21967 --- tests/unit/serve_test.ts | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) (limited to 'tests') diff --git a/tests/unit/serve_test.ts b/tests/unit/serve_test.ts index 363667066..4239221be 100644 --- a/tests/unit/serve_test.ts +++ b/tests/unit/serve_test.ts @@ -4034,3 +4034,28 @@ Deno.test( await server.finished; }, ); + +Deno.test({ + name: "HTTP Server test (error on non-unix platform)", + ignore: Deno.build.os !== "windows", +}, async () => { + await assertRejects( + async () => { + const ac = new AbortController(); + const server = Deno.serve({ + path: "path/to/socket", + handler: (_req) => new Response("Hello, world"), + signal: ac.signal, + onListen({ path: _path }) { + console.log(`Server started at ${_path}`); + }, + }); + server.finished.then(() => console.log("Server closed")); + console.log("Closing server..."); + ac.abort(); + await new Promise((resolve) => setTimeout(resolve, 100)); // Example of awaiting something + }, + Error, + 'Operation `"op_net_listen_unix"` not supported on non-unix platforms.', + ); +}); -- cgit v1.2.3